Improve error for PRs from forks #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
faximan
reviewed
Jun 12, 2023
There was a problem hiding this comment.
Thanks Rodrigo! Could you also remove https://github.com/googlecloudrobotics/core/blob/main/.github/ci/common.sh#LL14C8-L14C73 as it seems broken/insufficient?
I am afraid this means we have no solution for supporting presubmits from external contributors (non-org members). I can file a tracking bug about this.
This has confused us a few times.
This doesn't seem to work as expected. This reverts commit f744e9f.
drigz
force-pushed
the
rodrigoq/better-error
branch
from
4e171fc
to
b676aef
Compare
|
@faximan PTAL, looks like I forgot this PR. |
faximan
approved these changes
Jul 24, 2023
faximan
added a commit
that referenced
this pull request
Jul 24, 2023
After #163 this file was no longer present, which manifests as a broken postsubmit: https://console.cloud.google.com/cloud-build/builds;region=europe-west1/a9a2ed28-0966-49ae-acb4-5e6b11187010;step=1?project=robco-integration-test Also fixing a missing rename in #159 Postsubmit passes with this PR: https://pantheon.corp.google.com/cloud-build/builds;region=europe-west1/6e67162e-b19d-435a-8726-15c3bf202255?project=robco-integration-test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has confused us a few times.