webhook fixup

The webhook was being overwritten and not used.
The actual implementation was too aggressive, in not allowing apps with
no version i.e. versionlabel = "" to go through

This fixes both

src/app_charts/base/cloud/app-management.yaml

@@ -104,14 +104,6 @@ webhooks:
     resources:
     - apps
   sideEffects: None
----
-apiVersion: admissionregistration.k8s.io/v1
-kind: ValidatingWebhookConfiguration
-metadata:
-  name: app-rollout-controller
-  annotations:
-    cert-manager.io/inject-ca-from: {{ .Release.Namespace }}/app-rollout-controller
-webhooks:
 - name: approllouts.apps.cloudrobotics.com
   admissionReviewVersions: ["v1"]
   failurePolicy: Fail

src/go/pkg/controller/approllout/controller.go

@@ -756,7 +756,7 @@ func appValidate(cur *apps.App) error {
 	appName, anok := cur.Labels[labelAppName]
 	appVersion, avok := cur.Labels[labelAppVersion]
 	if anok {
-		if avok {
+		if avok && appVersion != "" {
 			// both name and version are defined
 			ename := strings.ToLower(fmt.Sprintf("%s.v%s", appName, appVersion))
 			if ename != name {