This repository was archived by the owner on Mar 13, 2018. It is now read-only.
Fix toggle overloading bug #12
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was wondering why the ugly grey toggle was being applied to these buttons, turns out paper-button-base was looking to see whether toggle was set on the element (it has an "if (this.toggle)") but paper-dropdown overloaded toggle with the a function, causing "if (this.toggle)" to resolve to true due to JS's lack of type system. Either way, renaming the on-tap event here to anything other than toggle (I chose toggleDropdown) fixes the issue.
|
Thanks Owen. This workaround LGTM. Deferring to @morethanreal for her review. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was wondering why the ugly grey toggle was being applied to these buttons, turns out paper-button-base was looking to see whether toggle was set on the element (it has an "if (this.toggle)") but paper-dropdown overloaded toggle with the a function, causing "if (this.toggle)" to resolve to true due to JS's lack of type system.
Either way, renaming the on-tap event here to anything other than toggle (I chose toggleDropdown) fixes the issue.