Skip to content
This repository has been archived by the owner on Aug 25, 2018. It is now read-only.

Web tweaks, preparing to open source #18

Merged
merged 2 commits into from
Nov 26, 2014
Merged

Web tweaks, preparing to open source #18

merged 2 commits into from
Nov 26, 2014

Conversation

mimming
Copy link
Contributor

@mimming mimming commented Nov 26, 2014

  • Switched to placeholder Firebase name to match readme
  • Fixed a couple nits on web
  • Added a log message on web when auth fails, since there are lots of ways auth could get configured wrong

@alexwolfe or @joeyyang: Would either of you mind giving the tiny web changes a quick review? k thx :)

@@ -51,7 +51,7 @@ gulp.task("webpack", function() {
var stream = gulp.src('resources/js/app.js')
.pipe(webpack({
output: {
filename: 'production.js',
filename: 'production.js'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@alexwolfe
Copy link
Contributor

k, looks good. merge when ready!

mimming added a commit that referenced this pull request Nov 26, 2014
Web tweaks, preparing to open source
@mimming mimming merged commit c1a290c into master Nov 26, 2014
@mimming mimming deleted the jt-web-tweaks branch November 26, 2014 22:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants