This repository has been archived by the owner on Apr 22, 2020. It is now read-only.
Include JAVA_KEYWORDS in ALL_KEYWORDS #408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JAVA_KEYWORDS was inadvertently removed from ALL_KEYWORDS in d0fd4e3, breaking several tests. This also corrects a test to note a known bug. In the "java" test in prettify_test.html, we incorrectly highlight "remove" as a keyword, since that's a C# keyword and the language is not specified. One preexisting test failure remains after this change: The "dart" test in prettify_test.html fails due to 0dc62dc.
sfreilich
referenced
this pull request
Dec 3, 2015
Updated `CSHARP_KEYWORDS` section with the new keywords introduced in C# 6. Based on the official list of [C# keywords](https://msdn.microsoft.com/en-us/library/x53a06bb.aspx).
mikesamuel
added a commit
that referenced
this pull request
Dec 4, 2015
Include JAVA_KEYWORDS in ALL_KEYWORDS
|
Thanks. I missed this and "fixed" the tests other ways so this might have some fallout, but I'll fix that. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JAVA_KEYWORDS was inadvertently removed from ALL_KEYWORDS in d0fd4e3,
breaking several tests.
This also corrects a test to note a known bug. In the "java" test in
prettify_test.html, we incorrectly highlight "remove" as a keyword,
since that's a C# keyword and the language is not specified.
One preexisting test failure remains after this change: The "dart" test
in prettify_test.html fails due to 0dc62dc.