This repository was archived by the owner on Apr 23, 2021. It is now read-only.
Fix Issue 9 #10
Merged
Fix Issue 9 #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We might also want to add an id (http://developer.chrome.com/apps/app.window.html#method-create) so that if this isn't what people want -- think 30-inch monitor on Chromebox -- they can adjust it and it'll remember the previous position. Thoughts? |
|
I also think the window should be singleton'ed. |
…ndow will actually remember its position when resized, closed, and reopened.
|
@sowbug Testing the above on my Chromebook in question (since the only way to get Git on a Chromebook is with the developer switch on) right now... Let's see what happens. |
|
Okay, confirmed: Merely adding an ID suddenly allows the bounds to be remembered even when the window is destroyed. As for singletoning it as @dinhviethoa mentioned: "singleton: true" according to the app.window API is the default behavior, so no issues there. |
dinhvh
pushed a commit
that referenced
this pull request
Aug 30, 2013
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make the code editor less dependent on screen resolution, my changes to the code editor being pull-requested against perform calculations using screen.availWidth and screen.availHeight to create the window in proportion to said bounds. Hopefully they will be accepted upstream... Screenshot of what the changes do attached below.
