Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(python_library): fix unit test dependency installation #811

Merged

Conversation

daniel-sanche
Copy link
Contributor

Perviously, system tests allow users to pass in separate lists for system_test_external_dependencies and unit_test_local_dependencies, which would install dependencies needed for the test. Unit tests only had a single option called unit_test_dependencies, which only supported local packages.

This PR makes unit tests consistent with system tests by handling unit_test_external_dependencies and unit_test_local_dependencies. I kept unit_test_dependencies around with it's previous behaviour for backwards compatibility, in case any repos are using it as-is.

@daniel-sanche daniel-sanche requested a review from a team as a code owner October 16, 2020 01:06
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 16, 2020
@busunkim96 busunkim96 added the automerge Merge the pull request once unit tests and other checks pass. label Oct 26, 2020
@gcf-merge-on-green gcf-merge-on-green bot merged commit fd3584b into googleapis:master Oct 26, 2020
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants