Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: update dependencies check to only check for runtime and compile scopes #678

Merged
merged 9 commits into from
Aug 6, 2020
Merged

build: update dependencies check to only check for runtime and compile scopes #678

merged 9 commits into from
Aug 6, 2020

Conversation

salehsquared
Copy link
Contributor

Changes the dependencies.sh kokoro script to only compare 'compile' and 'runtime' scoped dependencies between the flattened POM and original POM.

This follows an issue recently noted within the java-bigquerystorage libraries in which inconsistent behavior with 'provided' scope transitive dependencies.

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 20, 2020
@stephaniewang526
Copy link
Contributor

stephaniewang526 commented Jul 21, 2020

this should be renamed to be feat: update dependencies check to only check for runtime and compile scopes

update both subject and commit msg. To update commit msg run git rebase -i master and then when prompted, pick reword, modify commit msg, finally git push --force.

@salehsquared salehsquared changed the title change:Updated dependencies check to only use runtime & compile scope feat: update dependencies check to only check for runtime and compile scopes Jul 21, 2020
@stephaniewang526 stephaniewang526 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 22, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 22, 2020
@stephaniewang526
Copy link
Contributor

@saturnism @elharo this is for verifying flattened pom vs. original pom completeness

@chingor13 chingor13 changed the title feat: update dependencies check to only check for runtime and compile scopes build: update dependencies check to only check for runtime and compile scopes Jul 22, 2020
@chingor13 chingor13 added the automerge Merge the pull request once unit tests and other checks pass. label Jul 22, 2020
@chingor13 chingor13 removed the automerge Merge the pull request once unit tests and other checks pass. label Jul 22, 2020
@busunkim96 busunkim96 closed this Jul 31, 2020
@salehsquared salehsquared requested a review from bcoe as a code owner July 31, 2020 15:52
@stephaniewang526 stephaniewang526 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 3, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 3, 2020
@stephaniewang526 stephaniewang526 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 5, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 5, 2020
@stephaniewang526
Copy link
Contributor

@chingor13 could you merge this one please?

@stephaniewang526 stephaniewang526 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 5, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 5, 2020
@stephaniewang526 stephaniewang526 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 6, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 6, 2020
@SurferJeffAtGoogle SurferJeffAtGoogle merged commit f8823de into googleapis:master Aug 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants