fix(python): apply post-processing spec to full package name#2095
Merged
vchudnov-g merged 2 commits intomasterfrom Jun 5, 2025
Merged
fix(python): apply post-processing spec to full package name#2095vchudnov-g merged 2 commits intomasterfrom
vchudnov-g merged 2 commits intomasterfrom
Conversation
Thus disambiguates replacement spec paths when a package name is a substring of another. Incidentally, made assertions more informative and removed a level of nesting.
1 task
parthea
approved these changes
Jun 5, 2025
vchudnov-g
added a commit
to googleapis/google-cloud-python
that referenced
this pull request
Jun 5, 2025
Update to the newest version of the post processor which includes the changes from the following PRs googleapis/synthtool#2095 Run the following commands to obtain the latest sha256 ``` docker pull gcr.io/cloud-devrel-public-resources/owlbot-python-mono-repo:latest ``` ``` docker inspect --format='{{.RepoDigests}}' gcr.io/cloud-devrel-public-resources/owlbot-python-mono-repo:latest [gcr.io/cloud-devrel-public-resources/owlbot-python-mono-repo@sha256:2ac1cedc5dbd030511de3ae6652cb0580bda09f99a2207ca423b54b6bf4b9c4c] ```
vchudnov-g
added a commit
to googleapis/google-cloud-python
that referenced
this pull request
Jun 5, 2025
Update to the newest version of the post processor which includes the changes from googleapis/synthtool#2095 Run the following commands to obtain the latest sha256 ``` docker pull gcr.io/cloud-devrel-public-resources/owlbot-python-mono-repo:latest docker inspect --format='{{.RepoDigests}}' gcr.io/cloud-devrel-public-resources/owlbot-python-mono-repo:latest [gcr.io/cloud-devrel-public-resources/owlbot-python-mono-repo@sha256:51c46627d1f458524c608810f7c8d30e8ac8fe029bd19d37bb8326689c3c56ec] ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thus disambiguates replacement spec paths when a package name is a substring of another.
Incidentally, this also makes some assertions more informative and removes a level of nesting.