Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Java 8 unit test to build code in Java 17 and run tests on Java 8 #1800

Merged
merged 2 commits into from
Jun 22, 2023
Merged

chore: Java 8 unit test to build code in Java 17 and run tests on Java 8 #1800

merged 2 commits into from
Jun 22, 2023

Conversation

suztomo
Copy link
Member

@suztomo suztomo commented May 18, 2023 •
edited
Loading

It worked in googleapis/java-storage#2081 (closed after confirming it works).

  • Our Java projects are configured to produce Java 8-compatible bytecode via https://github.com/googleapis/java-shared-config/blob/main/pom.xml#L848. This change ensures this config is applied correctly.
  • This change also switches the JDK distribution of GitHub Actions to temurin from zulu.
  • For the repositories that mark "dependencies (8)" and "dependencies (11)" as required, they should point to only "dependencies (17)" via .github/sync-repo-settings.yaml. I'll create pull requests to the repositories, or add necessary commit to derived owl-bot-update-lock pull requests.

@suztomo suztomo changed the title chore: use build Java 17 and run tests on Java 8 chore: build Java 17 and run tests on Java 8 May 18, 2023
@suztomo suztomo changed the title chore: build Java 17 and run tests on Java 8 chore: in CI, build Java 17 and run tests on Java 8 May 18, 2023
@suztomo suztomo mentioned this pull request May 19, 2023
Closed
@suztomo suztomo changed the title chore: in CI, build Java 17 and run tests on Java 8 chore: Java 8 unit test to build code in Java 17 and run tests on Java 8 Jun 22, 2023
@suztomo suztomo marked this pull request as ready for review June 22, 2023 14:26
@suztomo suztomo requested a review from a team as a code owner June 22, 2023 14:26
@suztomo suztomo merged commit cbe0100 into googleapis:master Jun 22, 2023
@suztomo suztomo deleted the java_test_java8 branch June 22, 2023 15:05
@suztomo
Copy link
Member Author

suztomo commented Jun 22, 2023

This change also switches the JDK distribution of GitHub Actions to temurin from zulu.

I forgot to include this change.. To be done in another pull request.

This was referenced Jul 25, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meltsufin meltsufin meltsufin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@suztomo @meltsufin