Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(python): remove release post processing for python monorepo #1797

Merged
merged 5 commits into from
May 25, 2023

Conversation

parthea
Copy link
Contributor

@parthea parthea commented May 10, 2023

No description provided.

Copy link
Contributor

@vchudnov-g vchudnov-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like the idea of calling the code when we're not dealing with migration PRs, so the rest of the process keeps working.

As per our offline conversation, though, you think the replacement tool will be available shortly and don't want to complicate this PR. I'm grudgingly fine with that as long as (a) we clearly document the extra steps we need to take to release new libraries (or whether we should have a freeze on that!) until the new tool is ready, and (b) the tool lands soon so we can bring our toil and tech debt back down.

Consider merging this PR as close as makes sense to having the tool ready, if that helps minimize disruption to our process.

synthtool/languages/python_mono_repo.py Show resolved Hide resolved
synthtool/languages/python_mono_repo.py Show resolved Hide resolved
@parthea parthea marked this pull request as ready for review May 24, 2023 21:35
@parthea
Copy link
Contributor Author

parthea commented May 25, 2023

The tool will be available today. Docs will also be updated today. I'll keep this PR open until I have the CL and tool ready.

@parthea
Copy link
Contributor Author

parthea commented May 25, 2023

Created cl/535319618 to update the documentation for new client library generation using the new tool.

Marked PR googleapis/google-cloud-python#11181 as ready for review which contains the code for the new tool.

@parthea parthea merged commit 70ec260 into master May 25, 2023
@parthea parthea deleted the remove-post-processing-gapic-version-py-monorepo branch May 25, 2023 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants