chore: pin versions of dependencies for compatibility with Python 3.6 #1588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meltsufin
approved these changes
Sep 23, 2022
There was a problem hiding this comment.
@SurferJeffAtGoogle Do you mind taking a quick look to see if this is OK? Thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generating the requirements file without specifying the version results in dependency versions that are compatible with Python 3.10 (latest) and breaks our current release build. Since our release job uses Python 3.6, we need to pin the versions of the dependencies and transitive dependencies to the latest that is compatible with Python 3.6.
Note: The versions in the requirements.txt file have been manually verified with the versions used in the
releaseandpublish_javadocjobs.