Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(python): run lint / unit tests / docs as GH actions #1333

Merged
merged 5 commits into from
Jan 20, 2022

Conversation

parthea
Copy link
Contributor

@parthea parthea commented Jan 17, 2022

I tested the changes using the following commands after cloning synthtool

git checkout add-lint-unittest-docs-checks-as-github-actions
docker build -f docker/owlbot/python/Dockerfile -t movetoghactions .

Once the docker image was built, I ran the following commands in the root of python-access-approval.

docker run --user $(id -u):$(id -g) --rm -v $(pwd):/repo -w /repo movetoghactions

This should not impact the existing kokoro or docs pre-submit jobs as we are adding github action checks in parallel. Once this is merged, we can disable the kokoro/docs on a per repo basis.

@parthea parthea added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jan 17, 2022
@parthea parthea changed the title ci: run lint / unit tests / docs as GH actions ci(python): run lint / unit tests / docs as GH actions Jan 17, 2022
@parthea parthea force-pushed the add-lint-unittest-docs-checks-as-github-actions branch from aaa14d8 to 27494be Compare January 17, 2022 20:48
@parthea parthea removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jan 19, 2022
@parthea parthea marked this pull request as ready for review January 19, 2022 10:24
@parthea parthea requested a review from a team as a code owner January 19, 2022 10:24
@parthea parthea added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jan 19, 2022
@parthea
Copy link
Contributor Author

parthea commented Jan 19, 2022

Wait for EOD to merge to avoid hitting kokoro github quota

@parthea parthea removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jan 20, 2022
@parthea parthea merged commit 57be0cd into master Jan 20, 2022
@parthea parthea deleted the add-lint-unittest-docs-checks-as-github-actions branch January 20, 2022 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants