Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(python): rename default branch to main #1188

Merged
merged 5 commits into from
Sep 1, 2021
Merged

chore(python): rename default branch to main #1188

merged 5 commits into from
Sep 1, 2021

Conversation

parthea
Copy link
Contributor

@parthea parthea commented Aug 19, 2021 •
edited
Loading

All googleapis python repos (with exception of tooling) have migrated to use a default branch of main. See tracking issue here.

@parthea parthea added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Aug 19, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 19, 2021
@parthea parthea mentioned this pull request Aug 20, 2021
Closed
@tseaver tseaver mentioned this pull request Aug 30, 2021
Closed
@parthea parthea marked this pull request as ready for review September 1, 2021 10:47
@parthea parthea requested a review from a team as a code owner September 1, 2021 10:47
@parthea parthea changed the title [WIP] chore(python): rename default branch to main chore(python): rename default branch to main Sep 1, 2021
@parthea parthea removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Sep 1, 2021
tseaver
tseaver approved these changes Sep 1, 2021
View reviewed changes
Copy link
Contributor

@tseaver tseaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to update synthtool/gcp/templates/python_library/samples/AUTHORING_GUIDE.md and synthtool/gcp/templates/python_library/samples/CONTRIBUTING.md as well?

@parthea
Copy link
Contributor Author

parthea commented Sep 1, 2021

synthtool/gcp/templates/python_library/samples/AUTHORING_GUIDE.md and synthtool/gcp/templates/python_library/samples/CONTRIBUTING.md will be updated in a future PR as https://github.com/GoogleCloudPlatform/python-docs-samples has not migrated to main yet. I've added a TODO in the agenda for the python samples working group to discuss the impact of changing the default branch in python-docs-samples. The next meeting is on September 20th.

@parthea parthea merged commit 5c0fa62 into master Sep 1, 2021
@parthea parthea deleted the python-rename-default-branch-to-main branch September 1, 2021 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tseaver tseaver tseaver approved these changes

@busunkim96 busunkim96 Awaiting requested review from busunkim96

Assignees

@busunkim96 busunkim96

Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@parthea @tseaver @busunkim96