Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove usage of repos.json #645

Closed
Tracked by #730
JustinBeckwith opened this issue Jun 24, 2020 · 3 comments · Fixed by #649
Closed
Tracked by #730

Remove usage of repos.json #645

JustinBeckwith opened this issue Jun 24, 2020 · 3 comments · Fixed by #649
Assignees
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: process A process-related concern. May include testing, release, or the like.

Comments

@JustinBeckwith
Copy link
Contributor

For node.js, python, and java we currently use repos.json to identify all relevant repositories where autosynth should run.

We would like to delete this file. Thinking out loud - I'm not sure why we would need repos.json. I was thinking that each repository that requires synth should own it's own processes for updating, and use a kokoro job on a cron to run autosynth instead of relying on a top level configuration. There could be other answers :)

@JustinBeckwith JustinBeckwith added the type: process A process-related concern. May include testing, release, or the like. label Jun 24, 2020
@SurferJeffAtGoogle SurferJeffAtGoogle added the priority: p2 Moderately-important priority. Fix may not be included in next release. label Jun 24, 2020
@sofisl
Copy link
Contributor

sofisl commented Jun 24, 2020

@JustinBeckwith - This doesn't really have anything to do with synthtool, but we do use repos.json for sync-repo-settings bot. Not a big deal, but I think we'd need to replace it in some capacity to keep sloth running.

@JustinBeckwith
Copy link
Contributor Author

Yup - I'm slowly running through every usage, and making sure we have a tracking bug like this one.

@SurferJeffAtGoogle SurferJeffAtGoogle self-assigned this Jun 25, 2020
SurferJeffAtGoogle added a commit to SurferJeffAtGoogle/synthtool that referenced this issue Jun 25, 2020
Also, move code that was copied and pasted twice into a common py file.

fixes googleapis#645
SurferJeffAtGoogle added a commit that referenced this issue Jun 26, 2020
* fix: remove all dependencies on sloth

Also, move code that was copied and pasted twice into a common py file.

fixes #645

* fix import path to list_split_repositories

* consider a repo with most of its code written in Javascript or Typescript to be a nodejs repo and see if it has a synth.py file

* remove obsolete addendum files

* when querying a repo's language, ignore languages we don't care about like Shell

* ignore archived repos
@JustinBeckwith
Copy link
Contributor Author

Thank you!

yoshi-automation added a commit to googleapis/python-service-directory that referenced this issue Jul 1, 2020
* fix: remove all dependencies on sloth

Also, move code that was copied and pasted twice into a common py file.

fixes googleapis/synthtool#645

* fix import path to list_split_repositories

* consider a repo with most of its code written in Javascript or Typescript to be a nodejs repo and see if it has a synth.py file

* remove obsolete addendum files

* when querying a repo's language, ignore languages we don't care about like Shell

* ignore archived repos

Source-Author: Jeffrey Rennie <rennie@google.com>
Source-Date: Fri Jun 26 14:59:14 2020 -0700
Source-Repo: googleapis/synthtool
Source-Sha: d79dc99519468f365c51210436ad277757d12844
Source-Link: googleapis/synthtool@d79dc99
yoshi-automation added a commit to googleapis/python-bigquery-reservation that referenced this issue Jul 31, 2020
* fix: remove all dependencies on sloth

Also, move code that was copied and pasted twice into a common py file.

fixes googleapis/synthtool#645

* fix import path to list_split_repositories

* consider a repo with most of its code written in Javascript or Typescript to be a nodejs repo and see if it has a synth.py file

* remove obsolete addendum files

* when querying a repo's language, ignore languages we don't care about like Shell

* ignore archived repos

Source-Author: Jeffrey Rennie <rennie@google.com>
Source-Date: Fri Jun 26 14:59:14 2020 -0700
Source-Repo: googleapis/synthtool
Source-Sha: d79dc99519468f365c51210436ad277757d12844
Source-Link: googleapis/synthtool@d79dc99
yoshi-automation added a commit to googleapis/python-service-directory that referenced this issue Aug 1, 2020
* fix: remove all dependencies on sloth

Also, move code that was copied and pasted twice into a common py file.

fixes googleapis/synthtool#645

* fix import path to list_split_repositories

* consider a repo with most of its code written in Javascript or Typescript to be a nodejs repo and see if it has a synth.py file

* remove obsolete addendum files

* when querying a repo's language, ignore languages we don't care about like Shell

* ignore archived repos

Source-Author: Jeffrey Rennie <rennie@google.com>
Source-Date: Fri Jun 26 14:59:14 2020 -0700
Source-Repo: googleapis/synthtool
Source-Sha: d79dc99519468f365c51210436ad277757d12844
Source-Link: googleapis/synthtool@d79dc99
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: process A process-related concern. May include testing, release, or the like.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants