Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: plumb soft_deleted option for grpc GetObject #679

Merged
merged 3 commits into from
Sep 23, 2024

Conversation

ddelgrosso1
Copy link
Contributor

Fixes #<issue_number_goes_here>

It's a good idea to open an issue first for discussion.

  • Tests pass
  • Appropriate changes to README are included in PR

Copy link

codecov bot commented Sep 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.74%. Comparing base (61bce3c) to head (d58ddc5).
Report is 43 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #679      +/-   ##
==========================================
+ Coverage   98.69%   98.74%   +0.05%     
==========================================
  Files          50       50              
  Lines        8492     8753     +261     
==========================================
+ Hits         8381     8643     +262     
+ Misses        111      110       -1     
Flag Coverage Δ
unittests 98.74% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ddelgrosso1 ddelgrosso1 marked this pull request as ready for review September 16, 2024 23:13
@ddelgrosso1 ddelgrosso1 requested a review from a team as a code owner September 16, 2024 23:13
@ddelgrosso1 ddelgrosso1 merged commit acc2b58 into googleapis:main Sep 23, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants