chore: avoid using implicitly declared samples target in BUILD.bazel#994
Merged
chore: avoid using implicitly declared samples target in BUILD.bazel#994
Conversation
Now to include samples in the package we have to pass includeSamples = True in the build file such as:
java_gapic_assembly_gradle_pkg(
name = "google-cloud-accessapproval-v1-java",
deps = [
":accessapproval_java_gapic",
":accessapproval_java_grpc",
":accessapproval_java_proto",
":accessapproval_proto",
],
includeSamples = True,
)
product-auto-label
bot
added
the
samples
eaball35
changed the title
eaball35
changed the title
eaball35
changed the title
blakeli0
approved these changes
May 19, 2022
vam-google
approved these changes
May 20, 2022
Contributor
vam-google
left a comment
vam-google
left a comment
There was a problem hiding this comment.
LGTM, but please change the name of the new param to include_samples to match bazel naming convention
rules_java_gapic/java_gapic_pkg.bzl
Outdated
| def java_gapic_assembly_gradle_pkg( | ||
| name, | ||
| deps, | ||
| includeSamples = False, |
|
Kudos, SonarCloud Quality Gate passed!
|
suztomo
pushed a commit
that referenced
this pull request
Dec 16, 2022
…994) * chore: avoid using implictly declared target Now to include samples in the package we have to pass includeSamples = True in the build file such as: java_gapic_assembly_gradle_pkg( name = "google-cloud-accessapproval-v1-java", deps = [ ":accessapproval_java_gapic", ":accessapproval_java_grpc", ":accessapproval_java_proto", ":accessapproval_proto", ], includeSamples = True, ) * use snake case
suztomo
pushed a commit
that referenced
this pull request
Mar 21, 2023
….6.6 (#994) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.api.grpc:proto-google-iam-v1](https://togithub.com/googleapis/java-iam/proto-google-iam-v1) ([source](https://togithub.com/googleapis/java-iam)) | `1.6.4` -> `1.6.6` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>googleapis/java-iam</summary> ### [`v1.6.6`](https://togithub.com/googleapis/java-iam/blob/HEAD/CHANGELOG.md#​166-httpsgithubcomgoogleapisjava-iamcomparev165v166-2022-10-25) [Compare Source](https://togithub.com/googleapis/java-iam/compare/v1.6.5...v1.6.6) ##### Dependencies - Update dependency com.google.cloud:google-iam-policy to v1.6.5 ([#​489](https://togithub.com/googleapis/java-iam/issues/489)) ([ab8be40](https://togithub.com/googleapis/java-iam/commit/ab8be4088259b25799aa5df0e7cfe944a7da7956)) ### [`v1.6.5`](https://togithub.com/googleapis/java-iam/blob/HEAD/CHANGELOG.md#​165-httpsgithubcomgoogleapisjava-iamcomparev164v165-2022-10-24) [Compare Source](https://togithub.com/googleapis/java-iam/compare/v1.6.4...v1.6.5) ##### Dependencies - Update dependency com.google.apis:google-api-services-cloudresourcemanager to v3-rev20221016-2.0.0 ([#​479](https://togithub.com/googleapis/java-iam/issues/479)) ([728084c](https://togithub.com/googleapis/java-iam/commit/728084cba18609a511dd04d67a59a8b0a4c2a63d)) - Update dependency com.google.auth:google-auth-library-oauth2-http to v1.12.1 ([#​478](https://togithub.com/googleapis/java-iam/issues/478)) ([94e2ca1](https://togithub.com/googleapis/java-iam/commit/94e2ca1930ec67bf1d837e044c8a72d64b6eae45)) - Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.5 ([#​486](https://togithub.com/googleapis/java-iam/issues/486)) ([292042e](https://togithub.com/googleapis/java-iam/commit/292042ea315d3bff5b07e86b73d82fa290364a8a)) - Update dependency com.google.cloud:google-iam-policy to v1.6.4 ([#​475](https://togithub.com/googleapis/java-iam/issues/475)) ([b86f46c](https://togithub.com/googleapis/java-iam/commit/b86f46cd9115b5d07d867766e37d402d054768a2)) - Update dependency com.google.protobuf:protobuf-bom to v3.21.8 ([#​481](https://togithub.com/googleapis/java-iam/issues/481)) ([cb74130](https://togithub.com/googleapis/java-iam/commit/cb741301c1add6eb5e790de44caa7961e2ea055d)) - Update dependency com.google.protobuf:protobuf-java to v3.21.8 ([#​482](https://togithub.com/googleapis/java-iam/issues/482)) ([176de6c](https://togithub.com/googleapis/java-iam/commit/176de6cb499db8fde987f69df35038d9872fad25)) - Update dependency io.grpc:grpc-protobuf to v1.50.0 ([#​476](https://togithub.com/googleapis/java-iam/issues/476)) ([358383f](https://togithub.com/googleapis/java-iam/commit/358383fef13874226454c05464a615651ec5b0fb)) - Update dependency io.grpc:grpc-protobuf to v1.50.2 ([#​483](https://togithub.com/googleapis/java-iam/issues/483)) ([3c9999b](https://togithub.com/googleapis/java-iam/commit/3c9999b9b4daca5aa343005ca89055f7172ba2dc)) - Update dependency io.grpc:grpc-stub to v1.50.2 ([#​477](https://togithub.com/googleapis/java-iam/issues/477)) ([e2255ec](https://togithub.com/googleapis/java-iam/commit/e2255ecfe43a7aef250802cd1829771d4b3691d8)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-core). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4yNDEuMTEiLCJ1cGRhdGVkSW5WZXIiOiIzMi4yNDEuMTEifQ==-->
suztomo
pushed a commit
that referenced
this pull request
Mar 21, 2023
](https://renovatebot.com){kind=link}
🤖 I have created a release *beep* *boop* --- ## [2.8.24](https://togithub.com/googleapis/java-core/compare/v2.8.23...v2.8.24) (2022-10-26) ### Dependencies * Update dependency com.google.api.grpc:proto-google-iam-v1 to v1.6.6 ([#994](https://togithub.com/googleapis/java-core/issues/994)) ([6bda7ce](https://togithub.com/googleapis/java-core/commit/6bda7ce63b19eb44add041482edd1e3de1100cad)) * Update dependency com.google.code.gson:gson to v2.10 ([#995](https://togithub.com/googleapis/java-core/issues/995)) ([0244ed8](https://togithub.com/googleapis/java-core/commit/0244ed8813ba261f416014cf1eff7a267de23013)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now to include samples in the package we have to pass
include_samples = Truein the build file such as:Not including (as currently is) will result in no samples being included allowing us to roll out slower. This isn't whether samples will be generated but whether they would be included in the assembly package, that would require a more complicated change.
Follow up to: cl/446288272