Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: re-work Bazel build to accommodate Maven setup #936

Merged
merged 24 commits into from
Feb 18, 2022
Merged

Conversation

chanseokoh
Copy link
Contributor

@chanseokoh chanseokoh commented Feb 16, 2022

Changes:

  1. Moving src/test/resources/*.proto into src/test/proto/.
    This makes it natural to use protobuf-maven-plugin in a future Maven setup.

  2. Embedding service_config.proto into src/test/proto/.
    Instead of having Bazel pull the grpc-proto repo to reference service_config.proto there, this PR keeps a copy. The repo README says

    Non-Bazel users are expected to copy the proto files from this repo as needed.

    Optionally in the future, Maven could be configured to dynamically download the file, but I'm not sure if it's really worth it.

  3. Changes to Bazel *.java compilation setup
    Looks like Bazel is not so smart as I had hoped, and I think it is not efficient unless we compile *.java and declare it as a separate library first and then use it in java_binary() or java_test().

  4. Changes to how resource files are accessed in tests
    This is to make both Bazel and Maven tests work in harmony in the future.

@codecov
Copy link

codecov bot commented Feb 16, 2022

Codecov Report

Merging #936 (da19e0e) into main (2a3df94) will increase coverage by 3.75%.
The diff coverage is 54.54%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #936      +/-   ##
==========================================
+ Coverage   87.37%   91.13%   +3.75%     
==========================================
  Files         162      265     +103     
  Lines       16307    27632   +11325     
  Branches     1179     1203      +24     
==========================================
+ Hits        14248    25182   +10934     
- Misses       1717     2096     +379     
- Partials      342      354      +12     
Impacted Files Coverage Δ
...com/google/api/generator/test/framework/Utils.java 30.00% <50.00%> (ø)
...or/gapic/protoparser/SourceCodeInfoParserTest.java 91.13% <56.25%> (ø)
...le/api/generator/engine/JavaCodeGeneratorTest.java 100.00% <0.00%> (ø)
...ogle/api/generator/engine/lexicon/KeywordTest.java 100.00% <0.00%> (ø)
.../generator/gapic/model/GapicServiceConfigTest.java 98.76% <0.00%> (ø)
...m/google/api/generator/gapic/model/MethodTest.java 100.00% <0.00%> (ø)
...mposer/samplecode/SampleCodeJavaFormatterTest.java 91.30% <0.00%> (ø)
...rator/gapic/protoparser/ServiceYamlParserTest.java 100.00% <0.00%> (ø)
...ator/gapic/protoparser/ResourceNameParserTest.java 98.64% <0.00%> (ø)
...gle/api/generator/engine/lexicon/OperatorTest.java 100.00% <0.00%> (ø)
... and 95 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a3df94...da19e0e. Read the comment docs.

@chanseokoh chanseokoh merged commit 55cc23e into main Feb 18, 2022
@chanseokoh chanseokoh deleted the bazel-rework branch February 18, 2022 18:23
suztomo pushed a commit that referenced this pull request Mar 21, 2023
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [google-cloud-core](https://togithub.com/googleapis/python-cloud-core) | `==2.3.1` -> `==2.3.2` | [![age](https://badges.renovateapi.com/packages/pypi/google-cloud-core/2.3.2/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/pypi/google-cloud-core/2.3.2/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/pypi/google-cloud-core/2.3.2/compatibility-slim/2.3.1)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/pypi/google-cloud-core/2.3.2/confidence-slim/2.3.1)](https://docs.renovatebot.com/merge-confidence/) |

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost.

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-core).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4yMDguMSIsInVwZGF0ZWRJblZlciI6IjMyLjIwOC4xIn0=-->
suztomo pushed a commit that referenced this pull request Mar 21, 2023
🤖 I have created a release *beep* *boop*
---


## [2.8.17](googleapis/java-core@v2.8.16...v2.8.17) (2022-09-28)


### Dependencies

* Update dependency cachetools to v5 ([#943](googleapis/java-core#943)) ([1406c09](googleapis/java-core@1406c09))
* Update dependency certifi to v2022.9.24 ([#934](googleapis/java-core#934)) ([b6e1904](googleapis/java-core@b6e1904))
* Update dependency charset-normalizer to v2.1.1 ([#938](googleapis/java-core#938)) ([ac43d61](googleapis/java-core@ac43d61))
* Update dependency click to v8.1.3 ([#946](googleapis/java-core#946)) ([05fe31f](googleapis/java-core@05fe31f))
* Update dependency com.google.api.grpc:proto-google-common-protos to v2.9.4 ([#945](googleapis/java-core#945)) ([3ebff6f](googleapis/java-core@3ebff6f))
* Update dependency gcp-releasetool to v1.8.8 ([#935](googleapis/java-core#935)) ([0f99ae1](googleapis/java-core@0f99ae1))
* Update dependency google-api-core to v2.10.1 ([#947](googleapis/java-core#947)) ([dedddfe](googleapis/java-core@dedddfe))
* Update dependency google-auth to v2.12.0 ([#948](googleapis/java-core#948)) ([67e53aa](googleapis/java-core@67e53aa))
* Update dependency google-cloud-core to v2.3.2 ([#936](googleapis/java-core#936)) ([a0d2e3e](googleapis/java-core@a0d2e3e))
* Update dependency google-cloud-storage to v2.5.0 ([#949](googleapis/java-core#949)) ([6edc6e3](googleapis/java-core@6edc6e3))
* Update dependency google-crc32c to v1.5.0 ([#950](googleapis/java-core#950)) ([0dda0a2](googleapis/java-core@0dda0a2))
* Update dependency googleapis-common-protos to v1.56.4 ([#937](googleapis/java-core#937)) ([b22a2b1](googleapis/java-core@b22a2b1))
* Update dependency importlib-metadata to v4.12.0 ([#951](googleapis/java-core#951)) ([6abe579](googleapis/java-core@6abe579))
* Update dependency jeepney to v0.8.0 ([#952](googleapis/java-core#952)) ([6a392e8](googleapis/java-core@6a392e8))
* Update dependency jinja2 to v3.1.2 ([#953](googleapis/java-core#953)) ([18a54a7](googleapis/java-core@18a54a7))
* Update dependency keyring to v23.9.3 ([#954](googleapis/java-core#954)) ([5ceabaa](googleapis/java-core@5ceabaa))
* Update dependency markupsafe to v2.1.1 ([#955](googleapis/java-core#955)) ([f64e9bf](googleapis/java-core@f64e9bf))
* Update dependency protobuf to v3.20.2 ([#956](googleapis/java-core#956)) ([fb1aea6](googleapis/java-core@fb1aea6))
* Update dependency protobuf to v4 ([#944](googleapis/java-core#944)) ([6b02535](googleapis/java-core@6b02535))
* Update dependency pyjwt to v2.5.0 ([#939](googleapis/java-core#939)) ([cc8ba46](googleapis/java-core@cc8ba46))
* Update dependency requests to v2.28.1 ([#940](googleapis/java-core#940)) ([ec195e3](googleapis/java-core@ec195e3))
* Update dependency typing-extensions to v4.3.0 ([#941](googleapis/java-core#941)) ([4c414e9](googleapis/java-core@4c414e9))
* Update dependency zipp to v3.8.1 ([#942](googleapis/java-core#942)) ([6dfb0d8](googleapis/java-core@6dfb0d8))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants