Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Diregapic lro #858

Merged
merged 21 commits into from
Oct 6, 2021
Merged
Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
1b7ee1e
feat: enable self signed jwt for gapic clients (#794)
arithmetic1728 Aug 17, 2021
7691f4e
chore: release 2.1.0 (#827)
release-please[bot] Aug 17, 2021
fdcfe70
feat: REGAPIC initial implementation (#824)
vam-google Aug 26, 2021
445daf4
feat: REGAPIC Multitransport implementation (grpc+rest) (#833)
vam-google Sep 6, 2021
92f7c1c
fix: [bazel] fix rest transport handling in assembly rule (#835)
vam-google Sep 7, 2021
556e7dd
Portable String <--> bytes conversion (#841)
chanseokoh Sep 14, 2021
d335340
Fix development doc (#837)
chanseokoh Sep 14, 2021
8ca140c
Remove warnings (unused vars, dead code, missing annotations, missing…
chanseokoh Sep 14, 2021
a7d905e
Remove warnings for test code (#842)
chanseokoh Sep 17, 2021
6a9f329
Remove extraneous call (#844)
chanseokoh Sep 17, 2021
98b891f
Fix preserving sorted order of a collection (#845)
chanseokoh Sep 20, 2021
cb1b534
feat: Add REST AIP-151 LRO suport
vam-google Sep 21, 2021
f569c11
chore(deps): update dependency gradle to v7 (#713)
renovate-bot Sep 29, 2021
73e5a3e
chore(deps): update dependency bazel_skylib to v1.0.3 (#722)
renovate-bot Sep 29, 2021
108e93d
chore(deps): update dependency bazel_skylib to v1.1.1 (#849)
renovate-bot Oct 1, 2021
cd84efe
chore(deps): update dependency gradle to v7.2 (#848)
renovate-bot Oct 1, 2021
3f0bf5a
chore: rename default branch to main (#851)
Neenu1995 Oct 4, 2021
aba0ec0
feat: enable self signed JWT for http (#850)
arithmetic1728 Oct 6, 2021
39c7b9c
Merge remote-tracking branch 'upstream/master' into diregapic-lro
vam-google Oct 6, 2021
d029941
chore: merge changes from master
vam-google Oct 6, 2021
0cf77b5
Merge remote-tracking branch 'upstream/main' into diregapic-lro
vam-google Oct 6, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove extraneous call (#844)
  • Loading branch information
chanseokoh authored Sep 17, 2021
commit 6a9f3290da649bddec1578fbfc95ef74f13674f1
Original file line number Diff line number Diff line change
Expand Up @@ -207,15 +207,12 @@ protected MethodDefinition createStartStaticServerMethod(
varInitExprs.add(initServiceHelperExpr);
varInitExprs.add(startServiceHelperExpr);

List<Statement> body = new ArrayList<>();

return MethodDefinition.builder()
.setAnnotations(Arrays.asList(AnnotationNode.withType(FIXED_TYPESTORE.get("BeforeClass"))))
.setScope(ScopeNode.PUBLIC)
.setIsStatic(true)
.setReturnType(TypeNode.VOID)
.setName("startStaticServer")
.setBody(body)
.setBody(
varInitExprs.stream().map(e -> ExprStatement.withExpr(e)).collect(Collectors.toList()))
.build();
Expand Down