Skip to content

chore: add TODO to allow-listed generation of unused resnames [ggj] #822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
miraleung merged 2 commits into from
Aug 6, 2021
Merged

chore: add TODO to allow-listed generation of unused resnames [ggj] #822

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5934d30
chore: add TODO to allow-listed generation of unused resnames
miraleung Aug 6, 2021
7953e4b
Merge branch 'master' into miraleung-patch-1
miraleung Aug 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/main/java/com/google/api/generator/gapic/protoparser/Parser.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,6 +164,8 @@ public static GapicContext parse(CodeGeneratorRequest request) {

Preconditions.checkState(!services.isEmpty(), "No services found to generate");

// TODO(vam-google): Figure out whether we should keep this allowlist or bring
// back the unused resource names for all APIs.
// Temporary workaround for Ads, who still need these resource names.
if (services.get(0).protoPakkage().startsWith("google.ads.googleads.v")) {
Function<ResourceName, String> typeNameFn =
Expand Down