Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove unneeded check of list nullness from extractResources method #753

Closed
wants to merge 1 commit into from

Conversation

dpcollins-google
Copy link

Fixes: #752

@dpcollins-google dpcollins-google requested review from miraleung and a team as code owners June 7, 2021 19:16
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jun 7, 2021
@miraleung
Copy link
Contributor

miraleung commented Jun 7, 2021

Closing - this change would have broken some of our client libraries, please see the context here.

@miraleung miraleung closed this Jun 7, 2021
@meltsufin meltsufin deleted the dpcollins-google-patch-1 branch January 29, 2022 01:30
suztomo pushed a commit that referenced this pull request Mar 21, 2023
….2.8 (#753)

[![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [com.google.api.grpc:proto-google-iam-v1](https://togithub.com/googleapis/java-iam) | `1.2.7` -> `1.2.8` | [![age](https://badges.renovateapi.com/packages/maven/com.google.api.grpc:proto-google-iam-v1/1.2.8/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.api.grpc:proto-google-iam-v1/1.2.8/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.api.grpc:proto-google-iam-v1/1.2.8/compatibility-slim/1.2.7)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.api.grpc:proto-google-iam-v1/1.2.8/confidence-slim/1.2.7)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>googleapis/java-iam</summary>

### [`v1.2.8`](https://togithub.com/googleapis/java-iam/blob/HEAD/CHANGELOG.md#&#8203;128-httpsgithubcomgoogleapisjava-iamcomparev127v128-2022-03-08)

[Compare Source](https://togithub.com/googleapis/java-iam/compare/v1.2.7...v1.2.8)

</details>

---

### Configuration

📅 **Schedule**: At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-core).
suztomo pushed a commit that referenced this pull request Mar 21, 2023
🤖 I have created a release *beep* *boop*
---


### [2.5.8](googleapis/java-core@v2.5.7...v2.5.8) (2022-03-08)


### Dependencies

* update dependency com.google.api.grpc:proto-google-iam-v1 to v1.2.8 ([#753](googleapis/java-core#753)) ([06a4fa6](googleapis/java-core@06a4fa6))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Protobuf fields should not be checked for nullness
2 participants