Skip to content

[ggj][engx][codegen] fix: handle back-compat casing for IAMCredentials API#601

Merged
miraleung merged 14 commits intomasterfrom
dev/a2
Dec 16, 2020
Merged

[ggj][engx][codegen] fix: handle back-compat casing for IAMCredentials API#601
miraleung merged 14 commits intomasterfrom
dev/a2

Conversation

@miraleung
Copy link
Contributor

IAMCredentials currently generates names with the casing "IamCredentials" for most classes, with "MockIAMCredentials" for the two mock classes. Meanwhile, protobuf uses any ALLCAPS names as they appear in the protos. We handle this one-off case for backwards compatibility, and there are no other APIs that share this special case.

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Dec 15, 2020
Base automatically changed from dev/a1 to master December 16, 2020 01:43
@miraleung miraleung merged commit 6c06c55 into master Dec 16, 2020
@miraleung miraleung deleted the dev/a2 branch December 16, 2020 02:02
suztomo pushed a commit that referenced this pull request Mar 21, 2023
🤖 I have created a release \*beep\* \*boop\*
---
### Updating meta-information for bleeding-edge SNAPSHOT release.
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant