New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ggj][ast][engx] fix: validate non-null elements for VaporReference #467

Merged

miraleung merged 16 commits into master from gp/g14

Nov 7, 2020

Contributor

miraleung commented Nov 7, 2020

No description provided.

miraleung added 15 commits

November 6, 2020 17:13


          fix: swap assertEquals args in JavaWriterVisitorTest to match (expect…

…ed, actusl) order


          fix: swap assertEquals args in ImportWriterVisitorTest to match (expe…

67f3a15

…cted, actusl) order


          fix: add node validator to refactor/centralize null element checks

1e1a86b


          fix: validate non-null elements for IfStatement

115e9fb


          fix: validate non-null elements for AnonymousClassExpr

1dac120


          fix: validate non-null elements for BlockStatement

004d0f0


          fix: validate non-null elements for ClassDefinition

191e93c


          fix: validate non-null elements for ConcreteReference

fdb7160


          fix: validate non-null elements for ForStatement

96eca4b


          fix: validate non-null elements for GeneralForStatement

10924ee


          fix: validate non-null elements for MethodDefinition


          fix: validate non-null elements for PackageInfoDefinition

a5a572c


          fix: validate non-null elements for SynchronizedStatement

e366777


          fix: validate non-null elements for TryCatchStatement

ef10eba


          fix: validate non-null elements for VaporReference

miraleung requested review from summer-ji-eng and xiaozhenliu-gg5 as code owners

November 7, 2020 03:21

google-cla bot added the cla: yes label

Base automatically changed from gp/g13 to master

November 7, 2020 06:00


          Merge branch 'master' into gp/g14

63cf175

miraleung merged commit 5323b79 into master

miraleung deleted the gp/g14 branch

November 7, 2020 06:08

suztomo pushed a commit that referenced this pull request


          deps: update dependency com.google.cloud:google-iam-policy to v1.6.2 (#…

12a9dcb

…467)

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [com.google.cloud:google-iam-policy](https://togithub.com/googleapis/java-eventarc) ([source](https://togithub.com/googleapis/java-iam)) | `1.6.1` -> `1.6.2` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-iam-policy/1.6.2/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-iam-policy/1.6.2/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-iam-policy/1.6.2/compatibility-slim/1.6.1)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-iam-policy/1.6.2/confidence-slim/1.6.1)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>googleapis/java-iam</summary>

### [`v1.6.2`](https://togithub.com/googleapis/java-iam/blob/HEAD/CHANGELOG.md#&#8203;162-httpsgithubcomgoogleapisjava-iamcomparev161v162-2022-10-02)

[Compare Source](https://togithub.com/googleapis/java-iam/compare/v1.6.1...v1.6.2)

##### Documentation

-   **samples:** Update package names to match v2 ([#&#8203;424](https://togithub.com/googleapis/java-iam/issues/424)) ([3a4392a](https://togithub.com/googleapis/java-iam/commit/3a4392af5d222d349b2fb8352c041b7889be97b5))

##### Dependencies

-   Update dependency cachetools to v5 ([#&#8203;459](https://togithub.com/googleapis/java-iam/issues/459)) ([89ea28b](https://togithub.com/googleapis/java-iam/commit/89ea28b2d57b4bdb11b8d847af313c63c8023146))
-   Update dependency certifi to v2022.9.24 ([#&#8203;440](https://togithub.com/googleapis/java-iam/issues/440)) ([de6c438](https://togithub.com/googleapis/java-iam/commit/de6c438b7709e71bdcc2c1c47702b808f828a42f))
-   Update dependency charset-normalizer to v2.1.1 ([#&#8203;444](https://togithub.com/googleapis/java-iam/issues/444)) ([5715206](https://togithub.com/googleapis/java-iam/commit/57152061f264629aa0f09f2602abf6fe3b242945))
-   Update dependency click to v8.1.3 ([#&#8203;445](https://togithub.com/googleapis/java-iam/issues/445)) ([189a5c4](https://togithub.com/googleapis/java-iam/commit/189a5c4102bd6b9f4fbfc252a67019a7c5e23ee3))
-   Update dependency com.google.apis:google-api-services-cloudresourcemanager to v3-rev20220911-2.0.0 ([#&#8203;435](https://togithub.com/googleapis/java-iam/issues/435)) ([5d415a9](https://togithub.com/googleapis/java-iam/commit/5d415a98f4e7cede137b57e048ec70c21ea8376d))
-   Update dependency com.google.apis:google-api-services-cloudresourcemanager to v3-rev20220925-2.0.0 ([#&#8203;439](https://togithub.com/googleapis/java-iam/issues/439)) ([b17765b](https://togithub.com/googleapis/java-iam/commit/b17765b5e897bcef60aeef56ed2524b418f73b65))
-   Update dependency com.google.cloud:google-iam-policy to v1.6.1 ([#&#8203;434](https://togithub.com/googleapis/java-iam/issues/434)) ([18d4bc0](https://togithub.com/googleapis/java-iam/commit/18d4bc0cd7341123d00eeb5fa15606d058f12fa6))
-   Update dependency com.google.protobuf:protobuf-java to v3.21.7 ([#&#8203;463](https://togithub.com/googleapis/java-iam/issues/463)) ([8ad215f](https://togithub.com/googleapis/java-iam/commit/8ad215f4543f7ffcd891ed6e1b202fe1ddccd86f))
-   Update dependency gcp-releasetool to v1.8.8 ([#&#8203;441](https://togithub.com/googleapis/java-iam/issues/441)) ([31fec95](https://togithub.com/googleapis/java-iam/commit/31fec95f348f55c98dab665bec47d88f396a9611))
-   Update dependency google-api-core to v2.10.1 ([#&#8203;446](https://togithub.com/googleapis/java-iam/issues/446)) ([50d8221](https://togithub.com/googleapis/java-iam/commit/50d82218cb3056bb49173d7f5d4e7b0070717b0f))
-   Update dependency google-auth to v2.12.0 ([#&#8203;447](https://togithub.com/googleapis/java-iam/issues/447)) ([97b4c23](https://togithub.com/googleapis/java-iam/commit/97b4c236276d27be1e290334573ec6897c9e67c9))
-   Update dependency google-cloud-core to v2.3.2 ([#&#8203;442](https://togithub.com/googleapis/java-iam/issues/442)) ([00adc9a](https://togithub.com/googleapis/java-iam/commit/00adc9a8bf225a4c3d1509f9e6778ad10dd16e2e))
-   Update dependency google-cloud-storage to v2.5.0 ([#&#8203;448](https://togithub.com/googleapis/java-iam/issues/448)) ([df5cf74](https://togithub.com/googleapis/java-iam/commit/df5cf74ee883b7f4d99ce9654fcdd6a4670cc98a))
-   Update dependency google-crc32c to v1.5.0 ([#&#8203;449](https://togithub.com/googleapis/java-iam/issues/449)) ([a2f7304](https://togithub.com/googleapis/java-iam/commit/a2f7304a602b4621f43d4b3966586e0a7e1a7a2d))
-   Update dependency googleapis-common-protos to v1.56.4 ([#&#8203;443](https://togithub.com/googleapis/java-iam/issues/443)) ([c64de5a](https://togithub.com/googleapis/java-iam/commit/c64de5a5b2f3fcd9e17ed4963e586aaf0a1209ba))
-   Update dependency importlib-metadata to v4.12.0 ([#&#8203;450](https://togithub.com/googleapis/java-iam/issues/450)) ([e8607ce](https://togithub.com/googleapis/java-iam/commit/e8607ce4d1c6b202726b185560920c742e056a30))
-   Update dependency io.grpc:grpc-protobuf to v1.49.2 ([#&#8203;464](https://togithub.com/googleapis/java-iam/issues/464)) ([0d24035](https://togithub.com/googleapis/java-iam/commit/0d2403530080668411981679ec01801d5e756e03))
-   Update dependency io.grpc:grpc-stub to v1.49.2 ([#&#8203;465](https://togithub.com/googleapis/java-iam/issues/465)) ([2b67643](https://togithub.com/googleapis/java-iam/commit/2b67643239cf9cf617ddd3d15d176fbdb574d15e))
-   Update dependency jeepney to v0.8.0 ([#&#8203;451](https://togithub.com/googleapis/java-iam/issues/451)) ([56c8f86](https://togithub.com/googleapis/java-iam/commit/56c8f86e437f49636edd5673b4336def947de475))
-   Update dependency jinja2 to v3.1.2 ([#&#8203;452](https://togithub.com/googleapis/java-iam/issues/452)) ([0ebc062](https://togithub.com/googleapis/java-iam/commit/0ebc06212f4dc10f8724f35705d1db9ab148beac))
-   Update dependency markupsafe to v2.1.1 ([#&#8203;454](https://togithub.com/googleapis/java-iam/issues/454)) ([93bd5ec](https://togithub.com/googleapis/java-iam/commit/93bd5ec7183cf306e4956261321038b923861276))
-   Update dependency protobuf to v3.20.2 ([#&#8203;455](https://togithub.com/googleapis/java-iam/issues/455)) ([fb47671](https://togithub.com/googleapis/java-iam/commit/fb47671168b256e9b76ecc16e52cf0674cbefce7))
-   Update dependency protobuf to v4 ([#&#8203;460](https://togithub.com/googleapis/java-iam/issues/460)) ([cb9637c](https://togithub.com/googleapis/java-iam/commit/cb9637ce2ed8976deda7a146a3df738f6afd158c))
-   Update dependency pyjwt to v2.5.0 ([#&#8203;461](https://togithub.com/googleapis/java-iam/issues/461)) ([2d696a0](https://togithub.com/googleapis/java-iam/commit/2d696a04f036369b25a3dceb29f8f1b855136890))
-   Update dependency requests to v2.28.1 ([#&#8203;456](https://togithub.com/googleapis/java-iam/issues/456)) ([b023d05](https://togithub.com/googleapis/java-iam/commit/b023d05d096ae796573c488869682c45f1de57b2))
-   Update dependency typing-extensions to v4.3.0 ([#&#8203;457](https://togithub.com/googleapis/java-iam/issues/457)) ([53a369c](https://togithub.com/googleapis/java-iam/commit/53a369c5f157bcfb2752c6b6503d2f5e76c226b8))
-   Update dependency zipp to v3.8.1 ([#&#8203;458](https://togithub.com/googleapis/java-iam/issues/458)) ([39ea408](https://togithub.com/googleapis/java-iam/commit/39ea4087f4b72a57ee09d6f312d05f7607d89bfb))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-iam).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4yMTMuMCIsInVwZGF0ZWRJblZlciI6IjMyLjIxMy4wIn0=-->

suztomo pushed a commit that referenced this pull request


          chore(main): release 1.6.3 (#469)

66cab3d

🤖 I have created a release *beep* *boop*
---


## [1.6.3](https://togithub.com/googleapis/java-iam/compare/v1.6.2...v1.6.3) (2022-10-07)


### Dependencies

* Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.4 ([#468](https://togithub.com/googleapis/java-iam/issues/468)) ([6a1ae04](https://togithub.com/googleapis/java-iam/commit/6a1ae043eb7c2b4a6f3b8e5e516010ca07c5f36e))
* Update dependency com.google.cloud:google-iam-policy to v1.6.2 ([#467](https://togithub.com/googleapis/java-iam/issues/467)) ([12a9dcb](https://togithub.com/googleapis/java-iam/commit/12a9dcb0b2d31c5cbd4fdbae394e01c9ae91f112))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).

suztomo pushed a commit that referenced this pull request


          build(deps): update dependency com.google.cloud:google-cloud-shared-c…

a4e6099

…onfig to v1.5.4 (#467)

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [com.google.cloud:google-cloud-shared-config](https://togithub.com/googleapis/java-shared-config) | `1.5.3` -> `1.5.4` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-config/1.5.4/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-config/1.5.4/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-config/1.5.4/compatibility-slim/1.5.3)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-config/1.5.4/confidence-slim/1.5.3)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>googleapis/java-shared-config</summary>

### [`v1.5.4`](https://togithub.com/googleapis/java-shared-config/blob/HEAD/CHANGELOG.md#&#8203;154-httpsgithubcomgoogleapisjava-shared-configcomparev153v154-2022-10-19)

[Compare Source](https://togithub.com/googleapis/java-shared-config/compare/v1.5.3...v1.5.4)

##### Dependencies

-   Update auto-value-annotation.version to v1.10 ([#&#8203;521](https://togithub.com/googleapis/java-shared-config/issues/521)) ([601235c](https://togithub.com/googleapis/java-shared-config/commit/601235c32b6f1233d81a27788f6691cda05787af))
-   Update dependency com.puppycrawl.tools:checkstyle to v10.3.2 ([#&#8203;501](https://togithub.com/googleapis/java-shared-config/issues/501)) ([2b2c611](https://togithub.com/googleapis/java-shared-config/commit/2b2c611815cafd1809e27c769577ae55d481a170))
-   Update dependency com.puppycrawl.tools:checkstyle to v10.3.3 ([#&#8203;510](https://togithub.com/googleapis/java-shared-config/issues/510)) ([8d7f75d](https://togithub.com/googleapis/java-shared-config/commit/8d7f75de442cb3a274004faae430e9edf60730f3))
-   Update dependency com.puppycrawl.tools:checkstyle to v10.3.4 ([#&#8203;517](https://togithub.com/googleapis/java-shared-config/issues/517)) ([1119ba2](https://togithub.com/googleapis/java-shared-config/commit/1119ba29e4fe3a74a58c18961c3431570186cc27))
-   Update dependency org.graalvm.buildtools:junit-platform-native to v0.9.14 ([#&#8203;515](https://togithub.com/googleapis/java-shared-config/issues/515)) ([779a239](https://togithub.com/googleapis/java-shared-config/commit/779a2398f1310a2f23555dc5c861a5203364d7a1))
-   Update dependency org.graalvm.buildtools:junit-platform-native to v0.9.15 ([#&#8203;522](https://togithub.com/googleapis/java-shared-config/issues/522)) ([5dd225d](https://togithub.com/googleapis/java-shared-config/commit/5dd225dc5a66562c8496366986ef9dc401d9be92))
-   Update dependency org.graalvm.buildtools:native-maven-plugin to v0.9.14 ([#&#8203;516](https://togithub.com/googleapis/java-shared-config/issues/516)) ([5605094](https://togithub.com/googleapis/java-shared-config/commit/56050943045d5e3d94c8598791c695d3fefcfef0))
-   Update dependency org.graalvm.buildtools:native-maven-plugin to v0.9.15 ([#&#8203;523](https://togithub.com/googleapis/java-shared-config/issues/523)) ([45752ad](https://togithub.com/googleapis/java-shared-config/commit/45752ad7083f07d2ce81a23ea930aa9737473940))
-   Update dependency org.junit.vintage:junit-vintage-engine to v5.9.1 ([#&#8203;514](https://togithub.com/googleapis/java-shared-config/issues/514)) ([60c000c](https://togithub.com/googleapis/java-shared-config/commit/60c000c3736288b98382aae79eb21a5cb15258fb))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-common-protos).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4yNDAuNSIsInVwZGF0ZWRJblZlciI6IjMyLjI0MC41In0=-->

suztomo pushed a commit that referenced this pull request


          chore: release 2.2.2-SNAPSHOT (#467)

26c394a

🤖 I have created a release \*beep\* \*boop\*
---
### Updating meta-information for bleeding-edge SNAPSHOT release.
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

suztomo pushed a commit that referenced this pull request


          chore: release 1.95.1-SNAPSHOT (#467)

55a402a

🤖 I have created a release \*beep\* \*boop\*
---
### Updating meta-information for bleeding-edge SNAPSHOT release.
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels