-
Couldn't load subscription status.
- Fork 71
chore: update upper bound dependencies file #3966
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
chore: update upper bound dependencies file #3966
Conversation
Summary of ChangesHello @renovate-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on maintaining the project's dependency hygiene by updating the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates two dependencies, dev.cel:cel and com.google.crypto.tink:tink. While the update for dev.cel:cel appears to be safe, the update for com.google.crypto.tink:tink to version 1.19.0 introduces a critical breaking change. This new version of Tink requires Java 11, but the project is currently configured for Java 8. This incompatibility will likely cause build failures and must be addressed before merging.
| dev.cel:cel,dev.cel=0.11.0 | ||
| com.google.crypto.tink:tink,com.google.crypto.tink=1.18.0 | ||
| dev.cel:cel,dev.cel=0.11.1 | ||
| com.google.crypto.tink:tink,com.google.crypto.tink=1.19.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The update of com.google.crypto.tink:tink to version 1.19.0 introduces a breaking change. According to the release notes, this version requires Java 11, but this project is configured to use Java 8 (as specified by <maven.compiler.release>8</maven.compiler.release> in gapic-generator-java-pom-parent/pom.xml). This will cause build failures. It's recommended to revert this change until the project is upgraded to Java 11.
com.google.crypto.tink:tink,com.google.crypto.tink=1.18.0
9106072 to
71b62e5
Compare
This PR contains the following updates:
1.18.0->1.19.02.42.0->2.43.00.11.0->0.11.1Warning
Some dependencies could not be looked up. Check the Dependency Dashboard for more information.
Release Notes
tink-crypto/tink-java (com.google.crypto.tink:tink)
v1.19.0: Tink Java v1.19.0Compare Source
Tink is a multi-language, cross-platform library that provides simple and misuse-proof APIs for common cryptographic tasks.
This is Tink Java 1.19
The complete list of changes since 1.18.0 can be found here.
Build changes
Dependencies
Obscure behaviour changes
Tink will reject custom key types where the Type-Url has non-ASCII characters.
Tink may serialize keysets slightly differently in certain cases. For
example, in the serialization of a ECDSA keyset, the points might be padded
differently than before. Users should not depend on the exact format of
Tink's serialization.
Use Conscrypt's AES-CMAC implementation when available and when the input is larger than 64 byte. This may improves the performance of AES-CMAC, AES-SIV and AES-EAX for large inputs.
Removed usage of thread-local Ciphers for ChaCha20Poly1305.
Added APIs
Added public
JwtEcdsaParameters.Algorithm.getEcParameterSpecmethod.The AES-SIV implementation in subtle now accepts multiple associated datas.
Future work
To see what we're working towards, check our project roadmap.
Getting started
To get started using Tink, see the setup guide.
Maven:
Gradle:
Bazel:
Using bzlmod
Using WORKSPACE
Alternatively, one can build Tink from source, and include it with
http_archive:google/error-prone (com.google.errorprone:error_prone_annotations)
v2.43.0: Error Prone 2.43.0Changes:
-XepPatchChecksnow skips disabled checks (#4943)AndroidJdkLibsCheckerhas been removed, the recommended replacement for Android code is Android Lint's NewApi checkNew checks:
NullNeedsCastForVarargs: Detect calls that incorrectly passes anullarray instead of anullelement.RedundantNullCheck: detect checks on expressions that are non-null.Closed issues: #4943, #5102, #5107, #5121, #5158, #5217, #5239
Full changelog: google/error-prone@v2.42.0...v2.43.0
google/cel-java (dev.cel:cel)
v0.11.1Compare Source
Significant changes
Starting with this release, the runtime can evaluate these literals to the following Java native type equivalents:
This new behavior is not yet enabled by default. Call
CelOptions.Builder.evaluateCanonicalTypesToNativeValues(true)to explicitly enable it.What's Changed
Features
Optimizations
Safety
Bug fixes
"0.0 == -0.0"now evaluates totrueTesting infra
Miscellaneous
CelMutableExpr.ofComprehension. in #812Full Changelog: google/cel-java@v0.11.0...v0.11.1
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.
This PR was generated by Mend Renovate. View the repository job log.