Skip to content

deps: update dependency ch.qos.logback:logback-core to v1.5.19 [security] #3964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

deps: update dependency ch.qos.logback:logback-core to v1.5.19 [security] #3964

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion java-showcase/gapic-showcase/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@

<properties>
<gapic-showcase.version>0.36.2</gapic-showcase.version>
<slf4j1-logback.version>1.2.13</slf4j1-logback.version>
<slf4j1-logback.version>1.5.19</slf4j1-logback.version>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

Updating logback to version 1.5.19 in this profile introduces a critical compatibility issue. Logback version 1.5.x requires SLF4J 2.0.x, but the slf4j1_logback profile is configured to use slf4j-api:1.7.36. This mismatch will likely lead to LinkageError or other class loading issues at runtime.

To resolve this, you should use a logback version that is compatible with SLF4J 1.7.x. The 1.4.x series of logback is compatible. I suggest using the latest version in that series, 1.4.14, which also contains other recent security fixes.

If 1.5.19 is strictly required, the slf4j-api dependency in this profile must be upgraded to a 2.0.x version. In that case, I'd also recommend renaming the profile from slf4j1_logback to avoid future confusion.

Suggested change
<slf4j1-logback.version>1.5.19</slf4j1-logback.version>
<slf4j1-logback.version>1.4.14</slf4j1-logback.version>

</properties>

<build>
Expand Down
Loading