Skip to content

deps: update dependency ch.qos.logback:logback-core to v1.5.19 [security] #3963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

deps: update dependency ch.qos.logback:logback-core to v1.5.19 [security] #3963

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions java-showcase/gapic-showcase/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,7 +250,7 @@
<dependency>
<groupId>ch.qos.logback</groupId>
<artifactId>logback-core</artifactId>
<version>1.5.16</version>
<version>1.5.19</version>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

While updating logback-core to 1.5.19 is correct for the security fix, the corresponding logback-classic dependency on line 247 is still at 1.5.16. It is best practice to keep all modules of Logback at the same version to prevent potential runtime issues. Please consider updating logback-classic to 1.5.19 as well in this profile.

<scope>test</scope>
</dependency>
</dependencies>
Expand Down Expand Up @@ -339,7 +339,7 @@
<dependency>
<groupId>ch.qos.logback</groupId>
<artifactId>logback-core</artifactId>
<version>1.3.15</version>
<version>1.5.19</version>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This update introduces a critical incompatibility. The disabledLogging profile uses slf4j-api:1.7.36 (defined on line 330), but logback-core version 1.5.19 requires slf4j-api version 2.0.0 or higher. This mismatch will cause runtime errors like NoSuchMethodError.

This profile also has a version mismatch between logback-classic:1.2.13 and logback-core:1.5.19.

The previous version 1.3.15 was also incompatible with SLF4J 1.7.x.

To resolve this, the logging dependencies in this profile must be aligned. Given the other dependencies in this profile (slf4j-api:1.7.36 and logback-classic:1.2.13), it seems this profile is intended for SLF4J 1.x. If so, logback-core should be a version compatible with that, like 1.2.13. If an upgrade is necessary for security, the entire logging stack in this profile (slf4j-api, logback-classic, logback-core) should be upgraded to compatible versions (e.g., SLF4J 2.x and Logback 1.5.x).

<scope>test</scope>
</dependency>
</dependencies>
Expand Down
Loading