Skip to content

Comments

chore: update generation config#3749

Merged
diegomarquezp merged 17 commits intomainfrom
generate-libraries-main
Apr 18, 2025
Merged

chore: update generation config#3749
diegomarquezp merged 17 commits intomainfrom
generate-libraries-main

Conversation

@diegomarquezp
Copy link
Contributor

@diegomarquezp diegomarquezp commented Apr 17, 2025

Empty commit messages, skip creating pull request description.

Fixes #3745

@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Apr 17, 2025
@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. and removed size: s Pull request size is small. labels Apr 17, 2025
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: xl Pull request size is extra large. labels Apr 18, 2025
@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. and removed size: s Pull request size is small. labels Apr 18, 2025
@diegomarquezp diegomarquezp marked this pull request as ready for review April 18, 2025 01:07
python hermetic_build/common/cli/get_changed_libraries.py create \
--baseline-generation-config-path="${baseline_generation_config}" \
--current-generation-config-path="${generation_config}")
--current-generation-config-path="${generation_config}" | tee > "${changed_libraries_file}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tee command doesn't need ">".

--current-generation-config-path="${generation_config}")
--current-generation-config-path="${generation_config}" | tee > "${changed_libraries_file}"
changed_libraries=$(cat "${changed_libraries_file}")
echo "Changed libraries are: ${changed_libraries:-"No changed library"}."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect this double quotations included in double quotations. Check this before submitting this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I surrounded the whole variable with double quotes now.

Copy link
Member

@suztomo suztomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix/confirm the two points before merging this.

@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed for 'gapic-generator-java-root'

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
15.9% Duplication on New Code (required ≤ 3%)
B Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed for 'java_showcase_integration_tests'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@diegomarquezp diegomarquezp merged commit 3714eee into main Apr 18, 2025
53 of 56 checks passed
@diegomarquezp diegomarquezp deleted the generate-libraries-main branch April 18, 2025 01:53
lqiu96 pushed a commit that referenced this pull request Jun 10, 2025
`Empty commit messages, skip creating pull request description.`

Fixes #3745

---------

Co-authored-by: cloud-java-bot <cloud-java-bot@google.com>
lqiu96 pushed a commit that referenced this pull request Aug 21, 2025
`Empty commit messages, skip creating pull request description.`

Fixes #3745

---------

Co-authored-by: cloud-java-bot <cloud-java-bot@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: xl Pull request size is extra large.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Library generation fails due to missing commit

3 participants