Skip to content

Comments

build(deps): update dependency com.google.cloud:google-cloud-shared-config to v1.15.1#3724

Closed
renovate-bot wants to merge 1 commit intogoogleapis:mainfrom
renovate-bot:renovate/com.google.cloud-google-cloud-shared-config-1.x
Closed

build(deps): update dependency com.google.cloud:google-cloud-shared-config to v1.15.1#3724
renovate-bot wants to merge 1 commit intogoogleapis:mainfrom
renovate-bot:renovate/com.google.cloud-google-cloud-shared-config-1.x

Conversation

@renovate-bot
Copy link
Contributor

@renovate-bot renovate-bot commented Mar 27, 2025

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
com.google.cloud:google-cloud-shared-config 1.15.0 -> 1.15.1 age adoption passing confidence

Warning

Some dependencies could not be looked up. Check the Dependency Dashboard for more information.

Release Notes

googleapis/java-shared-config (com.google.cloud:google-cloud-shared-config)

v1.15.1

Compare Source

Dependencies
  • Update google-java-format to the latest (aa78b13)

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.

  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@trusted-contributions-gcf trusted-contributions-gcf bot added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 27, 2025
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Mar 27, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 27, 2025
@diegomarquezp diegomarquezp added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Mar 27, 2025
@diegomarquezp
Copy link
Contributor

diegomarquezp commented Mar 27, 2025

do not merge until #3723 is in

@diegomarquezp diegomarquezp removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Mar 28, 2025
@diegomarquezp
Copy link
Contributor

diegomarquezp commented Mar 28, 2025

Actually, #3723 is just part of the follow up. Since we don't expect releases of sdk-platform for at least 2 weeks, it's fine to merge this one in.

@diegomarquezp
Copy link
Contributor

diegomarquezp commented Mar 28, 2025

/gcbrun

@diegomarquezp diegomarquezp self-assigned this Mar 28, 2025
@diegomarquezp diegomarquezp mentioned this pull request Mar 28, 2025
Merged
3 tasks
@diegomarquezp
Copy link
Contributor

diegomarquezp commented Mar 28, 2025

Closed in favor of #3726, which prepares the repo for this upgrade.

@forking-renovate
Copy link

forking-renovate bot commented Mar 28, 2025

Renovate Ignore Notification

Because you closed this PR without merging, Renovate will ignore this update (1.15.1). You will get a PR once a newer version is released. To ignore this dependency forever, add it to the ignoreDeps array of your Renovate config.

If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR.

@renovate-bot renovate-bot deleted the renovate/com.google.cloud-google-cloud-shared-config-1.x branch March 28, 2025 19:53
diegomarquezp added a commit that referenced this pull request Apr 2, 2025
@diegomarquezp @renovate-bot @cloud-java-bot
chore(format): update google-java-format to 1.25.2 via java-shared-co…
4eed4d6 
…nfig update (#3726)

[Context
Doc](https://docs.google.com/document/d/1Fqb4lXZ0FEpkJoSUvUp7Ow-z0fdcLyLE30lDDsGaRY0/edit?resourcekey=0-IueNnA7qMxmyWH6bGE9bsw&tab=t.0#heading=h.pi1uh78box27)

This replaces #3724
in order to manually prepare the repo for this update. The preparation
includes:
 - Update google-cloud-shared-config to `1.15.1`.
- Configure pom.xml files to reference the `fmt` plugin using the
`com.spotify.fmt` groupId instead of `com.coveo`. The group ID in [since
2022](https://github.com/spotify/fmt-maven-plugin/blame/main/README.md#L7).
Some pom.xml explicitly referenced the `2.9.1` version, but I removed it
so it's [controlled by
google-cloud-shared-config](https://github.com/googleapis/java-shared-config/blob/bc8f22d02511c0467271698acf340874ed987160/java-shared-config/pom.xml#L172-L174).
- Update our `ci.yaml` to either run the `mvn` tasks using java 17 or
running the task with the `-Dfmt.skip` flag.
 - Update `java_compatibility_check.yaml` from java 11 to java 17.
 - Update our docker image to use java 17 instead of 11.
- Format the codebase using `mvn fmt:format` (see
36d9ee4
for format changes).


### Review instructions
You will see that the checks are failing because I did not include file
formatting in the latest commit of this PR for the sake of browser
performance. However, I ran the checks in
36d9ee4
with formatted files and they were all green except for the integration
test, which is failing because I haven't updated the golden branch (see
[this branch
comparison](googleapis/google-cloud-java@chore/test-hermetic-build...chore/test-hermetic-build-update-sharedconfig-and-lint)
for upcoming changes), which I plan to do before merging this PR.

#### Before merging:
 - [x] Update golden branch
 - [x] Restore hermetic_library_generation workflow
 - [x] Restore formatted java files

---------

Co-authored-by: Mend Renovate <bot@renovateapp.com>
Co-authored-by: cloud-java-bot <cloud-java-bot@google.com>
lqiu96 pushed a commit that referenced this pull request Jun 10, 2025
@diegomarquezp @renovate-bot
@cloud-java-bot @lqiu96
chore(format): update google-java-format to 1.25.2 via java-shared-co…
8296e97 
…nfig update (#3726)

[Context
Doc](https://docs.google.com/document/d/1Fqb4lXZ0FEpkJoSUvUp7Ow-z0fdcLyLE30lDDsGaRY0/edit?resourcekey=0-IueNnA7qMxmyWH6bGE9bsw&tab=t.0#heading=h.pi1uh78box27)

This replaces #3724
in order to manually prepare the repo for this update. The preparation
includes:
 - Update google-cloud-shared-config to `1.15.1`.
- Configure pom.xml files to reference the `fmt` plugin using the
`com.spotify.fmt` groupId instead of `com.coveo`. The group ID in [since
2022](https://github.com/spotify/fmt-maven-plugin/blame/main/README.md#L7).
Some pom.xml explicitly referenced the `2.9.1` version, but I removed it
so it's [controlled by
google-cloud-shared-config](https://github.com/googleapis/java-shared-config/blob/bc8f22d02511c0467271698acf340874ed987160/java-shared-config/pom.xml#L172-L174).
- Update our `ci.yaml` to either run the `mvn` tasks using java 17 or
running the task with the `-Dfmt.skip` flag.
 - Update `java_compatibility_check.yaml` from java 11 to java 17.
 - Update our docker image to use java 17 instead of 11.
- Format the codebase using `mvn fmt:format` (see
36d9ee4
for format changes).


### Review instructions
You will see that the checks are failing because I did not include file
formatting in the latest commit of this PR for the sake of browser
performance. However, I ran the checks in
36d9ee4
with formatted files and they were all green except for the integration
test, which is failing because I haven't updated the golden branch (see
[this branch
comparison](googleapis/google-cloud-java@chore/test-hermetic-build...chore/test-hermetic-build-update-sharedconfig-and-lint)
for upcoming changes), which I plan to do before merging this PR.

#### Before merging:
 - [x] Update golden branch
 - [x] Restore hermetic_library_generation workflow
 - [x] Restore formatted java files

---------

Co-authored-by: Mend Renovate <bot@renovateapp.com>
Co-authored-by: cloud-java-bot <cloud-java-bot@google.com>
lqiu96 pushed a commit that referenced this pull request Aug 21, 2025
@diegomarquezp @renovate-bot
@cloud-java-bot @lqiu96
chore(format): update google-java-format to 1.25.2 via java-shared-co…
0e251bd 
…nfig update (#3726)

[Context
Doc](https://docs.google.com/document/d/1Fqb4lXZ0FEpkJoSUvUp7Ow-z0fdcLyLE30lDDsGaRY0/edit?resourcekey=0-IueNnA7qMxmyWH6bGE9bsw&tab=t.0#heading=h.pi1uh78box27)

This replaces #3724
in order to manually prepare the repo for this update. The preparation
includes:
 - Update google-cloud-shared-config to `1.15.1`.
- Configure pom.xml files to reference the `fmt` plugin using the
`com.spotify.fmt` groupId instead of `com.coveo`. The group ID in [since
2022](https://github.com/spotify/fmt-maven-plugin/blame/main/README.md#L7).
Some pom.xml explicitly referenced the `2.9.1` version, but I removed it
so it's [controlled by
google-cloud-shared-config](https://github.com/googleapis/java-shared-config/blob/bc8f22d02511c0467271698acf340874ed987160/java-shared-config/pom.xml#L172-L174).
- Update our `ci.yaml` to either run the `mvn` tasks using java 17 or
running the task with the `-Dfmt.skip` flag.
 - Update `java_compatibility_check.yaml` from java 11 to java 17.
 - Update our docker image to use java 17 instead of 11.
- Format the codebase using `mvn fmt:format` (see
36d9ee4
for format changes).


### Review instructions
You will see that the checks are failing because I did not include file
formatting in the latest commit of this PR for the sake of browser
performance. However, I ran the checks in
36d9ee4
with formatted files and they were all green except for the integration
test, which is failing because I haven't updated the golden branch (see
[this branch
comparison](googleapis/google-cloud-java@chore/test-hermetic-build...chore/test-hermetic-build-update-sharedconfig-and-lint)
for upcoming changes), which I plan to do before merging this PR.

#### Before merging:
 - [x] Update golden branch
 - [x] Restore hermetic_library_generation workflow
 - [x] Restore formatted java files

---------

Co-authored-by: Mend Renovate <bot@renovateapp.com>
Co-authored-by: cloud-java-bot <cloud-java-bot@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@diegomarquezp diegomarquezp

Labels

size: s Pull request size is small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@renovate-bot @diegomarquezp @yoshi-kokoro