Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: demo offset parsing tests in java-core + java.time #3345

Draft
wants to merge 18 commits into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add obsoelte annotation
  • Loading branch information
diegomarquezp committed Nov 4, 2024
commit 1e28055bef35bcd7168cbdf1e0e6c82ad6c1a7e7
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@

import static com.google.common.base.Preconditions.checkArgument;

import com.google.api.core.ObsoleteApi;
import com.google.protobuf.util.Timestamps;
import java.io.Serializable;
import java.time.Instant;
Expand Down Expand Up @@ -190,6 +191,7 @@ public com.google.protobuf.Timestamp toProto() {
}

/** This method is obsolete. Use {@link #parseTimestampDuration(String)} instead */
@ObsoleteApi("Use parseTimestampDuration(String) instead")
public static Timestamp parseTimestamp(String timestamp) {
try {
return parseTimestampDuration(timestamp);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,7 @@ protected final void startProcess(String blockUntilOutput)
}

/** This method is obsolete. Use {@link #waitForProcessDuration(java.time.Duration)} instead */
@ObsoleteApi("Use waitForProcessDuration(java.time.Duration) instead")
protected final int waitForProcess(org.threeten.bp.Duration timeout)
throws IOException, InterruptedException, TimeoutException {
return waitForProcessDuration(toJavaTimeDuration(timeout));
Expand Down