Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Update Gapic generator and Gax to emit api-versioning via header #2671

Merged
merged 9 commits into from
Apr 26, 2024
Merged

feat: Update Gapic generator and Gax to emit api-versioning via header #2671

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
1eb09c2
add to ApiClientHeaderProvider and composer to emit header.
zhumin8 Apr 16, 2024
87be9f6
adding a golden test with api-version.
zhumin8 Apr 17, 2024
c0c8286
test: revert golden changes due to adding api-version to echo proto.
zhumin8 Apr 24, 2024
0a77f41
fix: avoid repeating logic.
zhumin8 Apr 24, 2024
c1febc9
test: test addition and changes with dedicated proto for testing this…
zhumin8 Apr 24, 2024
aef94cf
fix: remove redundant var for test.
zhumin8 Apr 24, 2024
96b954d
fix: fix mistake in manual merging.
zhumin8 Apr 24, 2024
24f2a5e
test: update showcase goldens after showcase changes in v0.33.0
zhumin8 Apr 24, 2024
aea6e77
test: remove redundant test after parameterizing.
zhumin8 Apr 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: remove redundant var for test.
  • Loading branch information
@zhumin8
zhumin8 committed Apr 24, 2024
commit aef94cf540ceaeab86317feb7b884f120e6aab82
7 changes: 4 additions & 3 deletions gax-java/gax/src/test/java/com/google/api/gax/rpc/ApiClientHeaderProviderTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@ public class ApiClientHeaderProviderTest {

private static final String X_GOOG_API_CLIENT = "x-goog-api-client";
private static final String CLOUD_RESOURCE_PREFIX = "google-cloud-resource-prefix";
private static final String API_VERSION_HEADER_KEY = "x-goog-api-version";

@Test
public void testServiceHeaderDefault() {
lqiu96 marked this conversation as resolved.
Show resolved Hide resolved
Expand Down Expand Up @@ -145,10 +144,12 @@ public void testApiVersionHeader() {
ApiClientHeaderProvider provider =
ApiClientHeaderProvider.newBuilder().setApiVersionToken("fake-version-string").build();
assertThat(provider.getHeaders().size()).isEqualTo(2);
assertThat(provider.getHeaders().get(API_VERSION_HEADER_KEY)).matches("fake-version-string");
assertThat(provider.getHeaders().get(ApiClientHeaderProvider.API_VERSION_HEADER_KEY))
.matches("fake-version-string");

ApiClientHeaderProvider emptyProvider =
ApiClientHeaderProvider.newBuilder().setApiVersionToken("").build();
assertThat(emptyProvider.getHeaders().get(API_VERSION_HEADER_KEY).isEmpty());
assertThat(
emptyProvider.getHeaders().get(ApiClientHeaderProvider.API_VERSION_HEADER_KEY).isEmpty());
}
}