Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add docker image for hermetic build scripts #2493

Merged
merged 54 commits into from
Feb 26, 2024
Merged
Changes from 1 commit
Commits
Show all changes
54 commits
Select commit Hold shift + click to select a range
683c31f
feat: add docker image for `library_generation` scripts
diegomarquezp Feb 8, 2024
5807d4e
add initial dockerfile
diegomarquezp Feb 8, 2024
d4cc19a
mark integration_tests.py as executable
diegomarquezp Feb 8, 2024
a5f3c8e
add dockerignore, improve dockerfile
diegomarquezp Feb 13, 2024
6ca4360
install more utils for scripts
diegomarquezp Feb 13, 2024
7e111b2
install more dependencies for docker image
diegomarquezp Feb 14, 2024
80d73ee
use is_monorepo to compute path to owlbot yaml
diegomarquezp Feb 14, 2024
1988bc5
Merge remote-tracking branch 'origin/main' into library-generation-do…
diegomarquezp Feb 14, 2024
f096c3c
allow mounting volumes via env vars
diegomarquezp Feb 16, 2024
bd81ca2
use `python` instead of `python3`
diegomarquezp Feb 16, 2024
24b591b
use ptyhon 3.11, install maven
diegomarquezp Feb 16, 2024
6880df9
properly install pip
diegomarquezp Feb 16, 2024
9c82bec
Revert "use `python` instead of `python3`"
diegomarquezp Feb 16, 2024
76965c2
fix symbolic link to python3
diegomarquezp Feb 16, 2024
bb95d9c
restore postprocess_library
diegomarquezp Feb 16, 2024
6ffde65
Merge remote-tracking branch 'origin/main' into library-generation-do…
diegomarquezp Feb 16, 2024
73ae31c
remove debug prints
diegomarquezp Feb 16, 2024
46ea110
remove debug print 2
diegomarquezp Feb 16, 2024
720d5f0
fix comment
diegomarquezp Feb 16, 2024
e622ccb
initial cloudbuild config
diegomarquezp Feb 20, 2024
b28fd30
move dockerfile to .cloudbuild
diegomarquezp Feb 20, 2024
70c5d82
restore run.sh
diegomarquezp Feb 20, 2024
5cbcdc6
adapt integration test for docker image
diegomarquezp Feb 20, 2024
ee1d5fd
fix typo in cloudbuild definition
diegomarquezp Feb 20, 2024
f6e73ae
add container IT script
diegomarquezp Feb 20, 2024
f39cb82
format source
diegomarquezp Feb 20, 2024
c7e30eb
Merge branch 'main' into library-generation-docker-image
diegomarquezp Feb 20, 2024
6c43da9
fix cloudbuild entrypoint
diegomarquezp Feb 20, 2024
f9894ba
Merge branch 'library-generation-docker-image-2' into library-generat…
diegomarquezp Feb 20, 2024
3671aeb
fix entrypoint for cloudbuild file
diegomarquezp Feb 20, 2024
5ab1d90
conditional volume removal
diegomarquezp Feb 20, 2024
a14f407
correct volume removal condition
diegomarquezp Feb 20, 2024
91cc061
do not use interactive mode
diegomarquezp Feb 20, 2024
60fd188
add image publishing to cloudbuild release yaml
diegomarquezp Feb 20, 2024
ade90e4
fix dockerfile year
diegomarquezp Feb 20, 2024
77214c6
move pull logic to its corresponding function
diegomarquezp Feb 20, 2024
ed45a9c
lint
diegomarquezp Feb 20, 2024
fbf133b
try with updated google-cloud-java test branch
diegomarquezp Feb 21, 2024
19f75f9
remove xtrace from postprocess library
diegomarquezp Feb 21, 2024
460ded2
Update library_generation/test/integration_tests.py
diegomarquezp Feb 21, 2024
53d1fe4
Update library_generation/test/integration_tests.py
diegomarquezp Feb 21, 2024
fa23a3c
Merge remote-tracking branch 'origin/library-generation-docker-image'…
diegomarquezp Feb 21, 2024
fbcf12e
use better variable names in IT
diegomarquezp Feb 21, 2024
0af136c
link a source of docker volumes comment
diegomarquezp Feb 21, 2024
e204536
fix variable name in IT
diegomarquezp Feb 21, 2024
8029dc2
lint
diegomarquezp Feb 21, 2024
d26c5da
add release cloudbuild yaml for library generation
diegomarquezp Feb 21, 2024
6248c2d
add comments for volume creationg
diegomarquezp Feb 24, 2024
2717c54
pass image_id as an argument from within cloudbuild
diegomarquezp Feb 24, 2024
c253f8d
remove quotes from tag id
diegomarquezp Feb 24, 2024
ad79348
correct quotes in image id
diegomarquezp Feb 24, 2024
a4bf286
use commit hash as image id version
diegomarquezp Feb 24, 2024
6ff386c
push both `latest` and `commit_sha` images
diegomarquezp Feb 24, 2024
dc520fb
Merge remote-tracking branch 'origin/main' into library-generation-do…
diegomarquezp Feb 24, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
link a source of docker volumes comment
  • Loading branch information
diegomarquezp committed Feb 21, 2024
commit 0af136c41ae37146b8e273ca28840ef9aa29f61b
1 change: 1 addition & 0 deletions library_generation/postprocess_library.sh
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,7 @@ preprocessed_libraries_binding="${owlbot_cli_source_folder}"
# being mapped from the host machine to the child container (instead of the
# parent container to child container) because we bind the `docker.sock` socket
# to the parent container (i.e. docker calls use the host's filesystem context)
# see https://serverfault.com/a/819371
# We solve this by referencing environment variables that will be
# set to produce the correct volume mapping.
diegomarquezp marked this conversation as resolved.
Show resolved Hide resolved
#
Expand Down
Loading