Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: check library_name is unique among libraries #2490

Merged
merged 4 commits into from
Feb 16, 2024

Conversation

JoeWang1127
Copy link
Collaborator

In this PR:

  • check whether library_name is unique among all libraries in configuration file.

@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Feb 16, 2024
@JoeWang1127 JoeWang1127 marked this pull request as ready for review February 16, 2024 01:53
@JoeWang1127 JoeWang1127 requested a review from a team as a code owner February 16, 2024 01:53
@diegomarquezp diegomarquezp added the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 16, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 16, 2024
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Feb 16, 2024
Copy link

sonarcloud bot commented Feb 16, 2024

Quality Gate Passed Quality Gate passed for 'gapic-generator-java-root'

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

sonarcloud bot commented Feb 16, 2024

Quality Gate Passed Quality Gate passed for 'java_showcase_integration_tests'

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@JoeWang1127 JoeWang1127 merged commit 8123f0b into main Feb 16, 2024
30 checks passed
@JoeWang1127 JoeWang1127 deleted the feat/check-library-name branch February 16, 2024 15:31
lqiu96 pushed a commit that referenced this pull request Feb 26, 2024
In this PR:
- check whether `library_name` is unique among all libraries in
configuration file.
lqiu96 pushed a commit that referenced this pull request Feb 28, 2024
In this PR:
- check whether `library_name` is unique among all libraries in
configuration file.
zhumin8 pushed a commit that referenced this pull request Feb 29, 2024
🤖 I have created a release *beep* *boop*
---


<details><summary>2.36.0</summary>

##
[2.36.0](v2.35.0...v2.36.0)
(2024-02-29)


### Features

* check library_name is unique among libraries
([#2490](#2490))
([8123f0b](8123f0b))


### Bug Fixes

* cleanup @BetaApi from Resource Name Builder Methods
([#2450](#2450))
([6e8d098](6e8d098)),
closes
[#2099](#2099)
* Fix watchdog to start with WAITING state
([#2468](#2468))
([dedc40f](dedc40f))
* ignore comment in BUILD
([#2492](#2492))
([6ca20e5](6ca20e5))
* remove @BetaApi from ApiFutures and ApiService
([#2454](#2454))
([f59e717](f59e717)),
closes
[#2098](#2098)


### Dependencies

* grandfathering the dependencies for java-pubsublite and java-bigquery
([#2504](#2504))
([9ceab23](9ceab23))
* update dependency gradle to v7.6.4
([#2474](#2474))
([607dc59](607dc59))
* update dependency org.graalvm.sdk:graal-sdk to v22.3.5
([#2475](#2475))
([2de487b](2de487b))
* update grpc dependencies to v1.62.2
([#2506](#2506))
([f438603](f438603))


### Documentation

* Add contribution guidelines.
([#2045](#2045))
([9939b43](9939b43))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants