Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: update gapic-showcase to v0.30.0 #2354

Merged
merged 2 commits into from
Jan 12, 2024
Merged

deps: update gapic-showcase to v0.30.0 #2354

merged 2 commits into from
Jan 12, 2024

Conversation

alicejli
Copy link
Contributor

Steps:

  1. Updated the gapic-showcase version in gapic-showcase/pom.xml to 0.30.0
  2. Ran mvn compile -P update

@alicejli alicejli requested a review from a team as a code owner January 10, 2024 22:18
@product-auto-label product-auto-label bot added the size: l Pull request size is large. label Jan 10, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jan 12, 2024

Quality Gate Failed Quality Gate failed for 'gapic-generator-java-root'

Failed conditions

0.0% Coverage on New Code (required ≥ 80%)
40.9% Duplication on New Code (required ≤ 3%)
B Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

idea Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jan 12, 2024

Quality Gate Passed Quality Gate passed for 'java_showcase_integration_tests'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@alicejli
Copy link
Contributor Author

Per #2234 (comment), it is okay to ignore the failing showcase-clirr check.

@alicejli alicejli merged commit 762c125 into main Jan 12, 2024
23 of 25 checks passed
@alicejli alicejli deleted the updateGapicShowcaseVersion branch January 12, 2024 21:10
@release-please release-please bot mentioned this pull request Jan 12, 2024
Merged
lqiu96 pushed a commit that referenced this pull request Jan 17, 2024
@alicejli @lqiu96
deps: update gapic-showcase to v0.30.0 (#2354)
3f927c3
@zhumin8 zhumin8 mentioned this pull request Apr 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lqiu96 lqiu96 lqiu96 approved these changes

Assignees
No one assigned
Labels
size: l Pull request size is large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alicejli @lqiu96