test: increasing timeout in testServerStreamingStart #2308
Merged
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #1678 The assertion error tells `latch.await(2, TimeUnit.SECONDS)` did not return true. https://docs.oracle.com/javase/8/docs/api/java/util/concurrent/CountDownLatch.html#await-long-java.util.concurrent.TimeUnit- > Returns: > true if the count reached zero and false if the waiting time elapsed before the count reached zero Under a multithreading test, there's no guarantee that `latch.await(2, TimeUnit.SECONDS)` finishes within 2 second. Increasing the value to 60 second to (drastically) reduce the flakiness.
|
|
JoeWang1127
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1678
The assertion error tells
latch.await(2, TimeUnit.SECONDS)did not return true.https://docs.oracle.com/javase/8/docs/api/java/util/concurrent/CountDownLatch.html#await-long-java.util.concurrent.TimeUnit-
Under a multithreading test, there's no guarantee that
latch.await(2, TimeUnit.SECONDS)finishes within 2 second.Increasing the value to 60 second to (drastically) reduce the flakiness. (This is the same tactics as #2291)
Will this 60-second timeout make the test execution slower? => No, it won't.
CountDownLatch.await(timeout)returns immediately when the count becomes zero, without waiting for timeout.