Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(main): release 2.23.0 #1806

Merged
merged 1 commit into from
Jul 7, 2023
Merged

chore(main): release 2.23.0 #1806

merged 1 commit into from
Jul 7, 2023

Conversation

release-please[bot]
Copy link
Contributor

@release-please release-please bot commented Jun 23, 2023

🤖 I have created a release beep boop

2.23.0 (2023-07-07)

Features

Bug Fixes

  • [gapic-generator-java] handle response and metadata type ambiguity in LRO parsing (#1726) (1ace494)
  • Abstract batch resource and add method to determine if batch should be flushed (#1790) (4c74107)

Dependencies

  • Bump grpc-java version to 1.55.3 (1ff8cc0)
  • Bump guava version to 32.1.1-jre (016e84d)
  • Bump j2obc-annotations version to 2.8 (4f45313)
  • Update google-auth-java-library to 1.19.0 (#1815) (41007a9)

This PR was generated with Release Please. See documentation.

@release-please release-please bot requested a review from a team as a code owner June 23, 2023 16:00
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jun 23, 2023
@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Jun 23, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 23, 2023
@release-please release-please bot force-pushed the release-please--branches--main branch from 3aae676 to 14097bf Compare June 26, 2023 14:57
@trusted-contributions-gcf trusted-contributions-gcf bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 26, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 26, 2023
@release-please release-please bot force-pushed the release-please--branches--main branch from 14097bf to 78c19f3 Compare June 27, 2023 16:00
@trusted-contributions-gcf trusted-contributions-gcf bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 27, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 27, 2023
@release-please release-please bot force-pushed the release-please--branches--main branch from 78c19f3 to a605395 Compare June 28, 2023 16:53
@trusted-contributions-gcf trusted-contributions-gcf bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 28, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 28, 2023
@release-please release-please bot changed the title chore(main): release 2.22.1 chore(main): release 2.23.0 Jun 28, 2023
@release-please release-please bot force-pushed the release-please--branches--main branch from a605395 to dde00df Compare June 28, 2023 22:40
@trusted-contributions-gcf trusted-contributions-gcf bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 28, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 28, 2023
@release-please release-please bot force-pushed the release-please--branches--main branch from dde00df to 0b8d8a1 Compare July 5, 2023 15:45
@trusted-contributions-gcf trusted-contributions-gcf bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 5, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 5, 2023
@release-please release-please bot force-pushed the release-please--branches--main branch from 0b8d8a1 to 1687c09 Compare July 7, 2023 14:12
@trusted-contributions-gcf trusted-contributions-gcf bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 7, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 7, 2023
@release-please release-please bot force-pushed the release-please--branches--main branch from 1687c09 to f6a4668 Compare July 7, 2023 14:23
@trusted-contributions-gcf trusted-contributions-gcf bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 7, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 7, 2023
@lqiu96
Copy link
Contributor

lqiu96 commented Jul 7, 2023

Error:

Run mvn versions:set -B -ntp -DnewVersion=local
  mvn versions:set -B -ntp -DnewVersion=local
  mvn clirr:check -B -ntp -Dclirr.skip=false -DcomparisonVersion=$SHOWCASE_CLIENT_VERSION
  shell: /usr/bin/bash -e {0}
  env:
    SHOWCASE_VERSION: 0.[2](https://github.com/googleapis/sdk-platform-java/actions/runs/5487448430/jobs/9998918783?pr=1806#step:6:2)8.2
    JAVA_HOME: /opt/hostedtoolcache/Java_Temurin-Hotspot_jdk/17.0.7-7/x64
    JAVA_HOME_17_X64: /opt/hostedtoolcache/Java_Temurin-Hotspot_jdk/17.0.7-7/x64
    SHOWCASE_CLIENT_VERSION: 0.0.1-SNAPSHOT
[INFO] Scanning for projects...
Error: ] Some problems were encountered while processing the POMs:
Error:  Non-resolvable import POM: Could not find artifact com.google.api:gax-bom:pom:2.[3](https://github.com/googleapis/sdk-platform-java/actions/runs/5487448430/jobs/9998918783?pr=1806#step:6:3)1.0 in google-maven-central-copy (https://maven-central.storage-download.googleapis.com/maven2) @ com.google.api:gapic-generator-java-bom:2.23.0, /home/runner/work/sdk-platform-java/sdk-platform-java/gapic-generator-java-bom/pom.xml, line 6[5](https://github.com/googleapis/sdk-platform-java/actions/runs/5487448430/jobs/9998918783?pr=1806#step:6:5), column 19
 @ 
Error:  The build could not read 1 project -> [Help 1]
Error:    
Error:    The project com.google.cloud:gapic-showcase-parent:0.0.1-SNAPSHOT (/home/runner/work/sdk-platform-java/sdk-platform-java/showcase/pom.xml) has 1 error
Error:      Non-resolvable import POM: Could not find artifact com.google.api:gax-bom:pom:2.31.0 in google-maven-central-copy (https://maven-central.storage-download.googleapis.com/maven2) @ com.google.api:gapic-generator-java-bom:2.23.0, /home/runner/work/sdk-platform-java/sdk-platform-java/gapic-generator-java-bom/pom.xml, line [6](https://github.com/googleapis/sdk-platform-java/actions/runs/5487448430/jobs/9998918783?pr=1806#step:6:6)5, column 1[9](https://github.com/googleapis/sdk-platform-java/actions/runs/5487448430/jobs/9998918783?pr=1806#step:6:9) -> [Help 2]
Error:  
Error:  To see the full stack trace of the errors, re-run Maven with the -e switch.
Error:  Re-run Maven using the -X switch to enable full debug logging.
Error:  
Error:  For more information about the errors and possible solutions, please read the following articles:
Error:  [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/ProjectBuildingException
Error:  [Help 2] http://cwiki.apache.org/confluence/display/MAVEN/UnresolvableModelException
Error: Process completed with exit code 1.

Error seems to be from using v2.30.0 of the gax-bom which hasn't been released yet (version is pulled from the version in the branch?). It might make sense to exclude this job from running in the release PR. Doesn't seem like a blocking issue, so I will proceed with this failed check.

@lqiu96
Copy link
Contributor

lqiu96 commented Jul 7, 2023

Oh, the docs for github.base_ref:

The base_ref or target branch of the pull request in a workflow run. This property is only available when the event that triggers a workflow run is either pull_request or pull_request_target.

This would point to the main branch which doesn't contain the non -SNAPSHOT version of the bom yet. I believe the ref should be pointed to the the release-please branch.

@release-please release-please bot force-pushed the release-please--branches--main branch from f6a4668 to 8aeab86 Compare July 7, 2023 16:53
@trusted-contributions-gcf trusted-contributions-gcf bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 7, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 7, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jul 7, 2023

[gapic-generator-java-root] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarcloud
Copy link

sonarcloud bot commented Jul 7, 2023

[java_showcase_integration_tests] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarcloud
Copy link

sonarcloud bot commented Jul 7, 2023

[java_showcase_unit_tests] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@lqiu96 lqiu96 merged commit b830aff into main Jul 7, 2023
@lqiu96 lqiu96 deleted the release-please--branches--main branch July 7, 2023 17:17
@release-please
Copy link
Contributor Author

release-please bot commented Jul 7, 2023

@release-trigger
Copy link

Triggered job: cloud-devrel/client-libraries/java/sdk-platform-java/release/stage (2023-07-07T17:17:52.863Z)

To trigger again, remove the autorelease: triggered label (in a few minutes).

@release-tool-publish-reporter
Copy link

The release build has started, the log can be viewed here. 🌻

@release-tool-publish-reporter
Copy link

🥚 You hatched a release! The release build finished successfully! 💜

lqiu96 pushed a commit that referenced this pull request Jul 12, 2023
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
lqiu96 added a commit that referenced this pull request Jul 17, 2023
* fix: Use bindings for resolving multi pattern resources

* chore: Fix lint issues

* chore: Add unit tests for the behavior

* chore: Add comments for the tests

* chore: Remove unused comment

* feat: support GDC-H Credentials  (#1642)

* chore: initial additions to handle GDC-H API audience

* chore: add unit tests for GDC-H

* chore: cleanup of logic

* chore: decompose tests into separate methods

* chore: fix clirr diff check

* chore: fmt:format

* chore: add support in `ClientSettings`

* chore: add showcase IT for GDCH credentials

* chore: comments

* chore: improve tests

* chore: add partial IT for testing context credential

* chore: recreate GdchCredentials with audience using convenience method

* chore: more readable api audience logic

* chore: no wildcard imports

* chore: javadoc for public methods

* chore: gdch test to use default null initialization

* chore: tear down for gdch IT

* chore: `assertThrows` for gdch ITs

* chore: mvn fmt:format

* test: remove context test

* docs: explain that audience will be overriden if set through client/stub settings

* test: test audience setting should modify initial credentials

* chore: clirr check

* chore: ignore gdch changes

* chore: format

* chore: default to endpoint if audience not provided

* test: refresh gdch creds to confirm audience works

* chore: fmt

* chore: fmt

* chore: better test names in ClientContextTest

* chore: better test names for showcase tests

* chore: simplify refresh verification logic

* chore: include outcome in gdch it test names

* chore: expand comments in GDCH ITs

* test: intercept mock transport to verify audience

* chore: fmt

* chore: move auth test-jar to shared dependencies

* chore: cleanup

* chore: use inferred version for auth library

* deps: update google-auth-java-library to 1.19.0

* choreL fmt ITGdch.java

* chore: import auth test-jar using common version variable

* chore: remove auth test-jar import from first-party-dependencies

* chore: add license headers to new files

* chore: revert google-auth-version to be obtained from main branch

* chore: correct showcase parent pom indentation

* chore: remove resource declaration for native test build

* fix: [gapic-generator-java] handle response and metadata type ambiguity in LRO parsing (#1726)

* chore: Bump grpc-java version to 1.55.3 (#1829)

* chore: Bump gapic-showcase version to 0.28.2 (#1830)

* build(deps): Bump guava version to 32.1.1-jre (#1832)

* chore: Bump guava version to 32.1.1-jre

* chore: Add guava to gradle template

* chore: Add j2obc-annotations to shared-dependencies (#1834)

* ci: fix showcase-clirr check on release PRs (#1835)

Install sdk-platform-java before performing final clirr check, so version changes are available in the local repository

* chore(main): release 2.23.0 (#1806)

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

* chore(main): release 2.23.1-SNAPSHOT (#1836)

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

* chore: Implement gRPC and HttpJson showcase tests for IAM (#1789)

* chore: Add framework for iam showcase tests

* chore: Generate clients with IAM stubs

* chore: Add IAM showcase tests

* chore: Add samples

* chore: Exclude httpjson tests

* chore: Use @before to create the resource

* chore: Use constant for policy

* chore: Log resource name

* chore: Test use setPolicyRequest's resourceName

* chore: run mvn clean before showcase tests

* chore: Attempt again with cache deleted

* chore: Add logging for test

* chore: Sleep for 1s

* chore: Use resource from setPolicyRequest

* chore: Ignore failing HttpJson test for now

* chore: Un-ignore test

* chore: Fix lint issues

* chore: Test with rooms/ prefix

* chore: Use Identity client for Users

* chore: Create user resource to assign policy to

* chore: Use user's name as resource id

* chore: Change resource name before each test

* chore: Add iam-grpc in pom

* chore: Resolve sonar issues

* chore: Add comment for testIamPolicy

* chore: Address PR comments

* ci: showcase native check (#1833)

* ci: showcase native check

* fix: add explicit java version

* fix: adjust syntax

* fix: add resource-config entry for ITGdch

* fix: copy file to temp folder so it can be accessed by path

* chore: formatting

* fix: prevent shutdown warnings with client.awaitTermination

* ci: fix build file location for downstream test

* chore: use static imports for Truth assertions

* chore: Resolve merge conflicts

* chore: Use bindings for any matching resource patterns

* chore: Fix lint issues

* chore: Remove unused code

* chore: Fix lint issues

* chore: Add test for resourceName matching bindings

* chore: Fix lint issues

---------

Co-authored-by: Diego Alonso Marquez Palacios <diegomarquezp@google.com>
Co-authored-by: Emily Wang <emmwang@google.com>
Co-authored-by: Burke Davison <40617934+burkedavison@users.noreply.github.com>
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autorelease: published kokoro:force-run Add this label to force Kokoro to re-run the tests. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant