Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: use Java 17 to produce Java 8-compatible bytecode #1681

Merged
merged 5 commits into from
May 15, 2023
Merged

test: use Java 17 to produce Java 8-compatible bytecode #1681

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7671f78
test: java 8 when running Java 8 test
suztomo May 15, 2023
d8d6dcd
touching Java 9 class
suztomo May 15, 2023
e7030b9
fully-qualified class name
suztomo May 15, 2023
40e54ee
Touching GraalVM's version class (major version: 55)
suztomo May 15, 2023
66741e0
Use Java 17 to produce Java 8-compatible bytecode
suztomo May 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
touching Java 9 class
  • Loading branch information
@suztomo
suztomo committed May 15, 2023
commit d8d6dcda4d7ad93d2b915982a4fef57b01475d91
4 changes: 4 additions & 0 deletions gax-java/gax-grpc/src/main/java/com/google/api/gax/grpc/ChannelPool.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,10 @@ class ChannelPool extends ManagedChannel {

static ChannelPool create(ChannelPoolSettings settings, ChannelFactory channelFactory)
throws IOException {

// ProcessHandle was introduced in Java 9
System.out.println("ProcessHandle: " + ProcessHandle.current());

return new ChannelPool(settings, channelFactory, Executors.newSingleThreadScheduledExecutor());
}

Expand Down