Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Spring CodeGen): write pom.xml with SpringWriter. #1057

Merged
merged 5 commits into from
Oct 26, 2022

Conversation

zhumin8
Copy link
Contributor

@zhumin8 zhumin8 commented Oct 5, 2022

This is a draft to generate pom.xml for Spring Starters modules. The placeholders in this generated file will be replaced in spring-cloud-gcp when triggering the generation (e.g. via script)

Update: updated to use utils added in #1061
We'll likely need to make more changes to pom generation depending on the project structure on spring-cloud-gcp side. But I'd like to merge this in first, and iterate as needed together with spring-cloud-gcp side.

@zhumin8 zhumin8 added the spring pr that's related to spring code gen, intend to merge into autoconfig-gen-draft2 branch. label Oct 5, 2022
@zhumin8 zhumin8 changed the title feat(Spring): [draft] write pom.xml with SpringWriter. feat(Spring CodeGen): [draft] write pom.xml with SpringWriter. Oct 5, 2022
@zhumin8 zhumin8 changed the title feat(Spring CodeGen): [draft] write pom.xml with SpringWriter. feat(Spring CodeGen): write pom.xml with SpringWriter. Oct 21, 2022
@zhumin8 zhumin8 marked this pull request as ready for review October 21, 2022 19:12
@zhumin8 zhumin8 requested review from a team as code owners October 21, 2022 19:12
Copy link
Contributor

@emmileaf emmileaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - some notes on possible future items:

  • Test coverage: will include testing for writePom as a todo for the SpringWriterTest task.
  • Would it be helpful to have a template-rendering setup here (e.g. with thymeleaf), instead of using String.format?

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
5.5% 5.5% Duplication

@zhumin8 zhumin8 merged commit c51d51b into autoconfig-gen-draft2 Oct 26, 2022
@zhumin8 zhumin8 deleted the write-pom branch October 26, 2022 15:34
suztomo pushed a commit that referenced this pull request Mar 21, 2023
…cp/templates/java_library/.kokoro (#1732) (#1057)

build(deps): bump certifi

Bumps [certifi](https://togithub.com/certifi/python-certifi) from 2022.9.24 to 2022.12.7.
- [Release notes](https://togithub.com/certifi/python-certifi/releases)
- [Commits](https://togithub.com/certifi/python-certifi/compare/2022.09.24...2022.12.07)

---
updated-dependencies:
- dependency-name: certifi
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Jeff Ching <chingor@google.com>
Source-Link: https://togithub.com/googleapis/synthtool/commit/ae0d43e5f17972981fe501ecf5a5d20055128bea
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:9de537d592b60e5eac73b374a28263969bae91ecdb29b445e894576fbf54851c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
spring pr that's related to spring code gen, intend to merge into autoconfig-gen-draft2 branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants