-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Spring CodeGen): write pom.xml with SpringWriter. #1057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhumin8
added
the
spring
pr that's related to spring code gen, intend to merge into autoconfig-gen-draft2 branch.
label
Oct 5, 2022
zhumin8
changed the title
feat(Spring): [draft] write pom.xml with SpringWriter.
feat(Spring CodeGen): [draft] write pom.xml with SpringWriter.
Oct 5, 2022
zhumin8
changed the title
feat(Spring CodeGen): [draft] write pom.xml with SpringWriter.
feat(Spring CodeGen): write pom.xml with SpringWriter.
Oct 21, 2022
emmileaf
approved these changes
Oct 24, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - some notes on possible future items:
- Test coverage: will include testing for
writePom
as a todo for theSpringWriterTest
task. - Would it be helpful to have a template-rendering setup here (e.g. with thymeleaf), instead of using
String.format
?
SonarCloud Quality Gate failed. |
suztomo
pushed a commit
that referenced
this pull request
Mar 21, 2023
…cp/templates/java_library/.kokoro (#1732) (#1057) build(deps): bump certifi Bumps [certifi](https://togithub.com/certifi/python-certifi) from 2022.9.24 to 2022.12.7. - [Release notes](https://togithub.com/certifi/python-certifi/releases) - [Commits](https://togithub.com/certifi/python-certifi/compare/2022.09.24...2022.12.07) --- updated-dependencies: - dependency-name: certifi dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Jeff Ching <chingor@google.com> Source-Link: https://togithub.com/googleapis/synthtool/commit/ae0d43e5f17972981fe501ecf5a5d20055128bea Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:9de537d592b60e5eac73b374a28263969bae91ecdb29b445e894576fbf54851c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
spring
pr that's related to spring code gen, intend to merge into autoconfig-gen-draft2 branch.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft to generate pom.xml for Spring Starters modules. The placeholders in this generated file will be replaced in spring-cloud-gcp when triggering the generation (e.g. via script)
Update: updated to use utils added in #1061
We'll likely need to make more changes to
pom
generation depending on the project structure onspring-cloud-gcp
side. But I'd like to merge this in first, and iterate as needed together withspring-cloud-gcp
side.