Skip to content

Commit

Permalink
Update AbstractServiceStubSettingsClassComposer.java
Browse files Browse the repository at this point in the history
  • Loading branch information
miraleung authored Jun 9, 2021
1 parent 868965e commit 6acd0cd
Showing 1 changed file with 2 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -582,7 +582,8 @@ private static Expr createPagedListDescriptorAssignExpr(
.build();

// While protobufs should not be null, this null-check is needed to protect against NPEs
// in paged iteration, as some clients actually return null instead of an empty list.
// in paged iteration on clients that use legacy HTTP/JSON types, as these clients can
// actually return null instead of an empty list.
// Context:
// Original issue: https://github.com/googleapis/google-cloud-java/issues/3736
// Relevant discussion where this check was first added:
Expand Down

0 comments on commit 6acd0cd

Please sign in to comment.