Skip to content

Conversation

diegomarquezp
Copy link

@diegomarquezp diegomarquezp commented Aug 25, 2025

The following problem has been observed in googleapis/java-bigquerystorage@96aa207

  • patterns starting with "/google-cloud..." only prevent deep-remove from affecting these folders
  • patterns starting with "/owl-bot-staging/.*" only prevent deep-copy from skipping these files.

In other words, /google.* basically prevents the matching files from being removed when cleaning up the repository. Later, when bringing the new generated files they may still be overridden if we don't have a similar pattern starting with /owl-bot-staging/v.*/... (that's the deep-copy part).

Using this debug branch we got:

***
source path: google/cloud/bigquery/storage/v1/generated-java/gapic-google-cloud-library/src/main/resources/META-INF/native-image/com.google.cloud.bigquery.storage.v1/reflect-config.json
full source path: /tmp/tmp.xidQiFQjW3/google/cloud/bigquery/storage/v1/generated-java/gapic-google-cloud-library/src/main/resources/META-INF/native-image/com.google.cloud.bigquery.storage.v1/reflect-config.json
rel path /owl-bot-staging/v1/google-cloud-bigquerystorage/src/main/resources/META-INF/native-image/com.google.cloud.bigquery.storage.v1/reflect-config.json
***
Excluding /owl-bot-staging/v1/google-cloud-bigquerystorage/src/main/resources/META-INF/native-image/com.google.cloud.bigquery.storage.v1/reflect-config.json.
wont copy /owl-bot-staging/v1/google-cloud-bigquerystorage/src/main/resources/META-INF/native-image/com.google.cloud.bigquery.storage.v1/reflect-config.json
***

Additionally, some manual testing confirmed the deep-preserve needs a different pattern starting with owl-bot-staging in order to prevent replacements:

Welcome to Node.js v20.19.2.
Type ".help" for more information.
> const relPath = '/owl-bot-staging/v1/google-cloud-bigquerystorage/src/main/resources/META-INF/native-image/com.google.cloud.bigquery.storage.v1/reflect-config.json'
undefined
> const exclude = '/^\/google-cloud-bigquerystorage\/src\/main\/resources\/META-INF\/native-image\//'
undefined
> relPath.test(exclude)
Uncaught TypeError: relPath.test is not a function
> const regex = new RegExp(exclude)
undefined
> regex.test(relPath)
false

@diegomarquezp diegomarquezp added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Aug 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: owl-bot do not merge Indicates a pull request not ready for merge, due to either quality or timing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant