Skip to content

feat(snippet-bot): add a summary of the region tag changes on PRs #1071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 3, 2020
Merged

feat(snippet-bot): add a summary of the region tag changes on PRs #1071

merged 5 commits into from
Nov 3, 2020

Conversation

tmatsuo
Copy link
Contributor

@tmatsuo tmatsuo commented Nov 2, 2020

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #1070

@tmatsuo tmatsuo requested a review from a team November 2, 2020 21:49
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 2, 2020
@tmatsuo
Copy link
Contributor Author

tmatsuo commented Nov 2, 2020

An example comment posted by the bot:
tmatsuo/python-docs-samples#17 (comment)

JustinBeckwith
JustinBeckwith approved these changes Nov 2, 2020
View reviewed changes
Copy link
Contributor

@JustinBeckwith JustinBeckwith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit, otherwise LGTM

chingor13
chingor13 reviewed Nov 3, 2020
View reviewed changes
bcoe
bcoe approved these changes Nov 3, 2020
View reviewed changes
Copy link

@bcoe bcoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 once @chingor13's comments are addressed.

JustinBeckwith
JustinBeckwith reviewed Nov 3, 2020
View reviewed changes
@tmatsuo tmatsuo force-pushed the snippet-bot-pr-comment branch from 33d4513 to 4048a8d Compare November 3, 2020 18:04
@tmatsuo
Copy link
Contributor Author

tmatsuo commented Nov 3, 2020

@chingor13 PTAL

@JustinBeckwith JustinBeckwith merged commit a7d3dc7 into googleapis:master Nov 3, 2020
@tmatsuo tmatsuo deleted the snippet-bot-pr-comment branch November 3, 2020 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chingor13 chingor13 chingor13 approved these changes

+2 more reviewers

@JustinBeckwith JustinBeckwith JustinBeckwith approved these changes

@bcoe bcoe bcoe approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat(snippet-bot): add a comment for region tag changes in the PR
4 participants
@tmatsuo @chingor13 @bcoe @JustinBeckwith