feat: use build-and-tag-action for creating dist #12
Conversation
index.js
Outdated
| await gr.createRelease() | ||
| const release = await gr.createRelease() | ||
| if (release) { | ||
| core.setOutput('tag_name', release.tag_name) |
There was a problem hiding this comment.
@JasonEtco I was concerned that having the undefined output might cause issues, will this be a noop?
There was a problem hiding this comment.
Should be fine! Would be a noop I believe.
There was a problem hiding this comment.
Left a note below for the workflow file stuff!
I have a question that might be a blocker - are the .hbs files part of the bundled action? The way build-and-tag-action works today only copies over the action.yml file and the package.json main file. Those won't be carried over - but that seems like a worthwhile feature addition!
| @@ -12,3 +12,9 @@ jobs: | |||
| token: ${{ secrets.GITHUB_TOKEN }} | |||
| release-type: node | |||
| package-name: release-please-action | |||
| - uses: JasonEtco/build-and-tag-action@v1 | |||
| with: | |||
| setup: 'npm ci && npm run build' | |||
There was a problem hiding this comment.
Because of actions/toolkit#461, this won't work 😞 Instead, you'll need:
- run: npm ci && npm run build
- uses: JasonEtco/build-and-tag-action@v1
with:
setup: ''You'll likely also need to use actions/checkout before being able to run those.
Yes the I'm wondering if I could just keep these checked in, since they're likely to change less often. |
this will now use
build-and-tag-actionto push thev1tag, and to create thedist/folder.