Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

fix: require google-cloud-core >= 1.4.4 #528

Merged
merged 1 commit into from
Oct 6, 2023
Merged

fix: require google-cloud-core >= 1.4.4 #528

merged 1 commit into from
Oct 6, 2023

Conversation

vchudnov-g
Copy link
Contributor

@vchudnov-g vchudnov-g commented Oct 5, 2023

This also removes the transitive dependency on package "six", which was causing presubmit failures.

BEGIN_COMMIT_OVERRIDE
fix: require google-cloud-core >= 1.4.4
END_COMMIT_OVERRIDE

@vchudnov-g vchudnov-g requested a review from a team as a code owner October 5, 2023 22:03
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: translate Issues related to the googleapis/python-translate API. labels Oct 5, 2023
@vchudnov-g vchudnov-g added the automerge Merge the pull request once unit tests and other checks pass. label Oct 5, 2023
@gcf-merge-on-green
Copy link
Contributor

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Oct 6, 2023
Copy link
Contributor

@parthea parthea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The conventional commit message should be fix: require google-cloud-core >= 1.4.4 to reflect the actual code changes. six is not a direct dependency of this library, however there is still a transitive dependency on six in google-cloud-core 1.x

@parthea parthea changed the title fix(deps): Remove dependency on package "six" fix: require google-cloud-core >= 1.4.4 Oct 6, 2023
@vchudnov-g vchudnov-g merged commit 8542583 into main Oct 6, 2023
16 checks passed
@vchudnov-g vchudnov-g deleted the remove-six branch October 6, 2023 15:06
@parthea parthea added the release-please:force-run To run release-please label Oct 19, 2023
@release-please release-please bot removed the release-please:force-run To run release-please label Oct 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api: translate Issues related to the googleapis/python-translate API. size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants