fix: drop gcloud-python header from user agent#449
Closed
Conversation
tseaver
added
status: blocked
product-auto-label
bot
added
the
api: storage
google-cla
bot
added
the
cla: yes
tseaver
changed the title
Contributor
|
Blocked by b/188672632 |
parthea
reviewed
May 26, 2021
| # TODO: When metrics all use gccl, this should be removed #9552 | ||
| if self._client_info.user_agent is None: # pragma: no branch | ||
| self._client_info.user_agent = "" | ||
| self._client_info.user_agent += " gcloud-python/{} ".format(__version__) |
Contributor
There was a problem hiding this comment.
When this code is removed, will the user-agent header be blank?
Contributor
There was a problem hiding this comment.
Hi @parthea, this change was made because tracking does not support x-goog-api-client header yet. If we were to remove this now, we would now see version numbers internally. It should still have a value from python core package for UserAgent. We are appending gcloud-python/{} which is supported right now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit dc817e9, added in googleapis/google-cloud-python#9551
Closes #25.
Note: do not merge until we have confirmation that the GCS back-end is using
gcclfor header processing.