Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add constraints file #337

Merged
merged 8 commits into from
Feb 9, 2021
Merged

Conversation

busunkim96
Copy link
Contributor

@busunkim96 busunkim96 commented Dec 4, 2020

Add constraints file to test lower bounds.

These files will not be used until the noxfile is changed in googleapis/synthtool#869.

@busunkim96 busunkim96 requested a review from a team December 4, 2020 00:50
@product-auto-label product-auto-label bot added the api: storage Issues related to the googleapis/python-storage API. label Dec 4, 2020
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Dec 4, 2020
@andrewsg
Copy link
Contributor

andrewsg commented Dec 7, 2020

Why the blank files for other py versions?

tseaver
tseaver previously approved these changes Dec 10, 2020
@tseaver tseaver dismissed their stale review December 10, 2020 18:19

Pointless

@tswast
Copy link
Contributor

tswast commented Dec 22, 2020

@andrewsg Re: "Why the blank files for other py versions?"

I added these in BigQuery because then we can always use a constraints file for every install step in the noxfile. An empty constraints file is a no-op.

These can also be customized to support other import versions besides the earliest, such as the latest/earliest version of a dependency package to support Python 3.7, for example. I had to do this in pandas-gbq to avoid installing numpy from source.

@tseaver tseaver self-requested a review February 9, 2021 20:33
@tseaver tseaver requested a review from a team as a code owner February 9, 2021 20:34
@tseaver tseaver added the automerge Merge the pull request once unit tests and other checks pass. label Feb 9, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit 2414a61 into master Feb 9, 2021
@gcf-merge-on-green gcf-merge-on-green bot deleted the add-constraints-file branch February 9, 2021 20:48
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Feb 9, 2021
cojenco pushed a commit to cojenco/python-storage that referenced this pull request Oct 13, 2021
Add constraints file to test lower bounds.

These files will not be used until the noxfile is changed in googleapis/synthtool#869.
cojenco pushed a commit to cojenco/python-storage that referenced this pull request Oct 13, 2021
Add constraints file to test lower bounds.

These files will not be used until the noxfile is changed in googleapis/synthtool#869.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the googleapis/python-storage API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants