Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: skip reporting coverage for namespace package, update secrets manager (via synth) #280

Merged
merged 7 commits into from
Sep 25, 2020
Merged

chore: skip reporting coverage for namespace package, update secrets manager (via synth) #280

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
238b295
chore(py-library): update decrypt secrets file
yoshi-automation Sep 24, 2020
3ba4642
chore(python-library): use sphinx 1.5.5 for the docfx job
yoshi-automation Sep 24, 2020
0a57b89
build(python): use release-publish app for notifying GitHub of releas…
yoshi-automation Sep 24, 2020
2059dd4
build(python): add secret manager in kokoro
yoshi-automation Sep 24, 2020
00a0587
chore(python): add sphinx doctest extension
yoshi-automation Sep 24, 2020
2fed6c6
chore(python): remove note about editable installs
yoshi-automation Sep 24, 2020
9ee8911
chore(python): skip reporting coverage for namespace package
yoshi-automation Sep 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore(python): remove note about editable installs 
`pip install -e .` is supported and is how we install the library for tests.

Source-Author: Bu Sun Kim <8822365+busunkim96@users.noreply.github.com>
Source-Date: Tue Sep 22 12:06:12 2020 -0600
Source-Repo: googleapis/synthtool
Source-Sha: a651c5fb763c69a921aecdd3e1d8dc51dbf20f8d
Source-Link: googleapis/synthtool@a651c5f
  • Loading branch information
@yoshi-automation
yoshi-automation committed Sep 24, 2020
commit 2fed6c65d624071ff53c297542f291aa54d74282
19 changes: 0 additions & 19 deletions CONTRIBUTING.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,25 +80,6 @@ We use `nox <https://nox.readthedocs.io/en/latest/>`__ to instrument our tests.

.. nox: https://pypi.org/project/nox/

Note on Editable Installs / Develop Mode
========================================

- As mentioned previously, using ``setuptools`` in `develop mode`_
or a ``pip`` `editable install`_ is not possible with this
library. This is because this library uses `namespace packages`_.
For context see `Issue #2316`_ and the relevant `PyPA issue`_.

Since ``editable`` / ``develop`` mode can't be used, packages
need to be installed directly. Hence your changes to the source
tree don't get incorporated into the **already installed**
package.

.. _namespace packages: https://www.python.org/dev/peps/pep-0420/
.. _Issue #2316: https://github.com/GoogleCloudPlatform/google-cloud-python/issues/2316
.. _PyPA issue: https://github.com/pypa/packaging-problems/issues/12
.. _develop mode: https://setuptools.readthedocs.io/en/latest/setuptools.html#development-mode
.. _editable install: https://pip.pypa.io/en/stable/reference/pip_install/#editable-installs

*****************************************
I'm getting weird errors... Can you help?
*****************************************
Expand Down
2 changes: 1 addition & 1 deletion synth.metadata
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
"git": {
"name": "synthtool",
"remote": "https://github.com/googleapis/synthtool.git",
"sha": "27f4406999b1eee29e04b09b2423a8e4646c7e24"
"sha": "a651c5fb763c69a921aecdd3e1d8dc51dbf20f8d"
}
}
],
Expand Down