Skip to content

test: add retry for default kms system test #198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 1, 2020

Conversation

IlyaFaer
Copy link

@IlyaFaer IlyaFaer commented Jul 1, 2020

Default KMS key name is eventually consistent. Adding a retry for the test to avoid flaky failures.

Closes #190

@IlyaFaer IlyaFaer added api: storage Issues related to the googleapis/python-storage API. testing labels Jul 1, 2020
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 1, 2020
@IlyaFaer IlyaFaer requested review from frankyn and andrewsg July 1, 2020 12:20
@IlyaFaer IlyaFaer marked this pull request as ready for review July 1, 2020 12:20
@andrewsg andrewsg merged commit 008224b into googleapis:master Jul 1, 2020
cojenco pushed a commit to cojenco/python-storage that referenced this pull request Oct 13, 2021
cojenco pushed a commit to cojenco/python-storage that referenced this pull request Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the googleapis/python-storage API. cla: yes This human has signed the Contributor License Agreement. testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test_system.TestKMSIntegration.test_bucket_w_default_kms_key_name failed
3 participants