feat(storage): change non_current_time type from datetime to date

google/cloud/storage/bucket.py

@@ -178,9 +178,9 @@ class LifecycleRuleConditions(dict):
                                         will become eligible for lifecycle action as soon as it becomes
                                         non current.
 
-    :type noncurrent_time_before: :class:`datetime.datetime`
-    :param noncurrent_time_before: (Optional) Datetime object parsed from RFC3339 valid timestamp, apply
-                                   rule action to items whose non current time is before this timestamp.
+    :type noncurrent_time_before: :class:`datetime.date`
+    :param noncurrent_time_before: (Optional) Date object parsed from iso8601 valid date, apply
+                                   rule action to items whose non current time is before this date.
                                    This condition is relevant only for versioned objects.
 
     :raises ValueError: if no arguments are passed.
@@ -221,9 +221,7 @@ def __init__(
             conditions["daysSinceNoncurrentTime"] = days_since_noncurrent_time
 
         if noncurrent_time_before is not None:
-            conditions["noncurrentTimeBefore"] = _datetime_to_rfc3339(
-                noncurrent_time_before
-            )
+            conditions["noncurrentTimeBefore"] = noncurrent_time_before.isoformat()
 
         super(LifecycleRuleConditions, self).__init__(conditions)
 
@@ -276,9 +274,9 @@ def days_since_noncurrent_time(self):
     @property
     def noncurrent_time_before(self):
         """Conditon's 'noncurrent_time_before' value."""
-        timestamp = self.get("noncurrentTimeBefore")
-        if timestamp is not None:
-            return _rfc3339_to_datetime(timestamp)
+        before = self.get("noncurrentTimeBefore")
+        if before is not None:
+            return datetime_helpers.from_iso8601_date(before)
 
 
 class LifecycleRuleDelete(dict):

tests/system/test_system.py

@@ -195,7 +195,7 @@ def test_lifecycle_rules(self):
         from google.cloud.storage import constants
 
         new_bucket_name = "w-lifcycle-rules" + unique_resource_id("-")
-        noncurrent_before = datetime.datetime.now() + datetime.timedelta(days=10)
+        noncurrent_before = datetime.date(2018, 8, 1)
         self.assertRaises(
             exceptions.NotFound, Config.CLIENT.get_bucket, new_bucket_name
         )

tests/unit/test_bucket.py

@@ -104,19 +104,15 @@ def test_ctor_w_days_since_noncurrent_time(self):
 
     def test_ctor_w_noncurrent_time_before(self):
         import datetime
-        import pytz
-        from google.cloud._helpers import _datetime_to_rfc3339
 
-        noncurrent_before = datetime.datetime.utcnow().replace(
-            tzinfo=pytz.UTC
-        ) + datetime.timedelta(days=10)
+        noncurrent_before = datetime.date(2018, 8, 1)
         conditions = self._make_one(
             number_of_newer_versions=3, noncurrent_time_before=noncurrent_before
         )
 
         expected = {
             "numNewerVersions": 3,
-            "noncurrentTimeBefore": _datetime_to_rfc3339(noncurrent_before),
+            "noncurrentTimeBefore": noncurrent_before.isoformat(),
         }
         self.assertEqual(dict(conditions), expected)
         self.assertIsNone(conditions.age)
@@ -128,12 +124,8 @@ def test_ctor_w_noncurrent_time_before(self):
 
     def test_from_api_repr(self):
         import datetime
-        import pytz
-        from google.cloud._helpers import _datetime_to_rfc3339
 
-        noncurrent_before = datetime.datetime.utcnow().replace(
-            tzinfo=pytz.UTC
-        ) + datetime.timedelta(days=10)
+        noncurrent_before = datetime.date(2018, 8, 1)
         before = datetime.date(2018, 8, 1)
         klass = self._get_target_class()
 
@@ -144,7 +136,7 @@ def test_from_api_repr(self):
             "matchesStorageClass": ["COLDLINE"],
             "numNewerVersions": 3,
             "daysSinceNoncurrentTime": 2,
-            "noncurrentTimeBefore": _datetime_to_rfc3339(noncurrent_before),
+            "noncurrentTimeBefore": noncurrent_before.isoformat(),
         }
         conditions = klass.from_api_repr(resource)
         self.assertEqual(conditions.age, 10)