Skip to content

chore: ensure full docs are generated through sphinx-docfx-yaml pipeline #1443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 26, 2025

Conversation

cojenco
Copy link
Contributor

@cojenco cojenco commented Feb 25, 2025

Unblock sphinx-docfx-yaml pipeline to generate full documentation by moving the contextmanager decorator within. Filed internal ticket b/394647066 to investigate why sphinx-generated yaml documentation drops parameters when a decorator is present.

@cojenco cojenco requested review from a team as code owners February 25, 2025 19:25
@product-auto-label product-auto-label bot added the size: xl Pull request size is extra large. label Feb 25, 2025
@product-auto-label product-auto-label bot added the api: storage Issues related to the googleapis/python-storage API. label Feb 25, 2025
@cojenco cojenco added the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 25, 2025
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 25, 2025
Copy link
Contributor

@andrewsg andrewsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this. Hopefully we can figure out what went wrong with Sphinx at a later date.

@andrewsg andrewsg requested a review from a team as a code owner February 26, 2025 00:22
@cojenco cojenco added the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 26, 2025
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 26, 2025
@cojenco cojenco merged commit 0378b44 into googleapis:main Feb 26, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the googleapis/python-storage API. size: xl Pull request size is extra large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants