-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: adding support for array testing in postgres #874
Conversation
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
044ccc6
to
43a3a39
Compare
tests/system/test_session_api.py
Outdated
PostGresAllTypesRowData(pkey=302, bool_array=[True, False, None]), | ||
PostGresAllTypesRowData(pkey=303, bytes_array=[BYTES_1, BYTES_2, None]), | ||
PostGresAllTypesRowData(pkey=304, date_array=[SOME_DATE, None]), | ||
PostGresAllTypesRowData(pkey=305, float_array=[3.1415926, 2.71828, None]), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we check for POS_INF
, and NEG_INF
as well?
Co-authored-by: Rajat Bhatta <93644539+rajatbhatta@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LTGM.
No description provided.