Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: adding support for array testing in postgres #874

Merged
merged 6 commits into from
Dec 27, 2022

Conversation

asthamohta
Copy link
Contributor

No description provided.

@asthamohta asthamohta requested review from a team as code owners December 26, 2022 17:18
@conventional-commit-lint-gcf
Copy link

conventional-commit-lint-gcf bot commented Dec 26, 2022

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@product-auto-label product-auto-label bot added size: s Pull request size is small. api: spanner Issues related to the googleapis/python-spanner API. labels Dec 26, 2022
tests/system/test_session_api.py Outdated Show resolved Hide resolved
PostGresAllTypesRowData(pkey=302, bool_array=[True, False, None]),
PostGresAllTypesRowData(pkey=303, bytes_array=[BYTES_1, BYTES_2, None]),
PostGresAllTypesRowData(pkey=304, date_array=[SOME_DATE, None]),
PostGresAllTypesRowData(pkey=305, float_array=[3.1415926, 2.71828, None]),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we check for POS_INF, and NEG_INF as well?

Copy link
Contributor

@rajatbhatta rajatbhatta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM.

@asthamohta asthamohta merged commit f4db562 into googleapis:main Dec 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the googleapis/python-spanner API. size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants