Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: deflake system test #866

Merged
merged 6 commits into from
Dec 13, 2022
Merged

test: deflake system test #866

merged 6 commits into from
Dec 13, 2022

Conversation

parthea
Copy link
Contributor

@parthea parthea commented Dec 9, 2022

Add try/finally around table creation in system tests to ensure cleanup when there is a failure.

@product-auto-label product-auto-label bot added size: l Pull request size is large. api: spanner Issues related to the googleapis/python-spanner API. labels Dec 9, 2022
@parthea parthea marked this pull request as ready for review December 12, 2022 14:38
@parthea parthea requested review from a team as code owners December 12, 2022 14:38
@parthea
Copy link
Contributor Author

parthea commented Dec 12, 2022

The failures appear to be unrelated. @asthamohta Please could you take a look?

@asthamohta asthamohta enabled auto-merge (squash) December 13, 2022 15:20
@parthea parthea added kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Dec 13, 2022
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Dec 13, 2022
@asthamohta asthamohta merged commit 234b21e into main Dec 13, 2022
@asthamohta asthamohta deleted the deflake-system-test branch December 13, 2022 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the googleapis/python-spanner API. size: l Pull request size is large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants